question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Mgmt] Add baseUrl customization for track2 SDK

See original GitHub issue

Currently we are using baseUri: options.endpoint || "https://management.azure.com/" in mgmt plane track2 SDK track2 link. which is different from what we did in the track1 SDK link this.baseUri = options.baseUri || this.baseUri || "https://management.azure.com"; I wonder why we remove the support of baseUri customization and use endpoint instead ?

customer suggest us to change it into

baseUri: options.endpoint ?? options.baseUri ?? "https://management.azure.com/"

see original issue here https://github.com/Azure/azure-sdk-for-js/issues/20651

Issue Analytics

  • State:open
  • Created 2 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

2reactions
joheredicommented, Mar 10, 2022

@bterlson, I think baseUri was inherited from core-http and we didn’t get rid of it 😞 in favor of endpoint. I think the way we can proceed right now is with 3 changes:

  1. Fix the generated code so that it honors baseUri, as Brian mentioned, endpoint should win over baseUri if both are present.
  2. Add endpoint to the ServiceClientOptions in core-client next to baseUri, also mark baseUri as deprecated to discourage users from using it, so that in the next major bump we take we can remove baseUri
  3. Remove endpoint from the generated code as it extends ServiceClientOptions and would get endpoint from there
0reactions
qiaozhacommented, Mar 10, 2022

@bterlson I guess this is probably because data plane is using endpoint since track1 and mgmt plane on the other hand is using baseUri. @joheredi feel free to correct me if I am wrong. Thanks

Read more comments on GitHub >

github_iconTop Results From Across the Web

options.baseUri is always overwritten by options.endpoint in ...
WebSiteManagementClient constructor ignores and overwrites the value of options.baseUri on the options: WebSiteManagementClientOptionalParams ...
Read more >
autorest-az - npm
Azure CLI Code Generator is an Autorest extension which generates functional Azure CLI code for Azure services by using Swagger specifications ...
Read more >
JBrowse 2 guide
These tracks provide the user with access to the filterable track and datapoints retrieved through the GDC API. Adding files via the add...
Read more >
Azure API Management Base URL - CLI Command
My APIM currently have multiple custom domains in it. My question is, how do you associated an API to a particular custom domain...
Read more >
Blog - Developer Docs
Added production URL; Redesigned app icons; Handle empty api base url ... Handle empty api base url; Change pending advice string ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found