Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[V4] Make the support for TokenCredentials behind a flag

See original GitHub issue

v4 generates client constructors which takes a credential as input if the --add-credentials parameter was used. This credential is an alternate between the old cred type and the @azure/identity’s TokenCredential. However the implementation for TokenCredential in @azure/ms-rest-js does not support AAD for all packages because the scope is hard coded for management-plane packages only. This means packages listed in can not use AAD when generated with v4. For more context, see So instead, we should support TokenCredential behind a flag that is off by default so that those packages do not get the buggy support for AAD.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

deyaaeldeencommented, Feb 17, 2022

v4 is still being used by a few data-plane packages (batch comes to mind) but @ramya-rao-a could help giving more context on the current situation.

JonathanCrdcommented, Mar 30, 2022

After spending some time with this task and having a couple of discussions regarding this task and the version 4 of the generator, I have concluded that this issue should be closed for the following reasons:

  • V4 is now deprecated, we are not introducing new features to it.
    • The development with v4x has become particularly problematic since many of its dependencies are now deprecated, not available anymore, and sometimes incompatible with today’s dev tools.
  • This functionality is present in the newer version of the generator, and most packages have already migrated to it.
  • This is not a customer reported issue, and it is not a critical fix.

Again, this issue does not represent a problem in v6, so packages that still depends on this can move to the newer version and get the latest features from the code generator.

Read more comments on GitHub >

github_iconTop Results From Across the Web

CosmosClientBuilder Class - Microsoft Learn
Helper class to build CosmosAsyncClient CosmosAsyncClient and CosmosClient ... Sets the TokenCredential used to authorize requests sent to the service.
Read more >
Specifying preauthentication and postauthentication activities for a ...
To customize the login process, you can write activities that will be triggered before and after token profile authentication.
Read more >
Azure/AppConfiguration · GitHub
Questions, feedback and samples for Azure App Configuration service ... Improved refresh for feature flags to reduce the number of calls made to...
Read more >
The remote server returned an error: (421) -Getting this error ...
I have registered the same in the Azure Directory. Currently using basic authentication ,I can download the mails from the Office 365 mailbox ......
Read more >
Configuring Token Authentication - Confluent Documentation
After this feature is generally available for use in production systems, ... Use one of the supported authentication methods like SASL or mTLS...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found