Invalid shader creating when running in exokit browser

Running http://www.babylonjs-playground.com/frame.htm#EIX8SD#3 in exokit (https://exokitbrowser.com) fails to function properly due to invalidly constructed shader (LOGARITHMICDEPTH is not defined)

Exokit logging:

Babylon.js engine (v3.3.0-alpha.13) launched BJS - [23:19:35]: Unable to compile effect: BJS - [23:19:35]: Uniforms: LensCenter, Scale, ScaleIn, HmdWarpParam, scale, textureSampler BJS - [23:19:35]: Attributes: position BJS - [23:19:35]: Error: unknown #version type: 300 es BJS - [23:19:35]: Unable to compile effect: BJS - [23:19:35]: Uniforms: world, view, viewProjection, vEyePosition, vLightsType, vAmbientColor, vDiffuseColor, vSpecularColor, vEmissiveColor, vFogInfos, vFogColor, pointSize, vDiffuseInfos, vAmbientInfos, vOpacityInfos, vReflectionInfos, vEmissiveInfos, vSpecularInfos, vBumpInfos, vLightmapInfos, vRefractionInfos, mBones, vClipPlane, diffuseMatrix, ambientMatrix, opacityMatrix, reflectionMatrix, emissiveMatrix, specularMatrix, bumpMatrix, normalMatrix, lightmapMatrix, refractionMatrix, diffuseLeftColor, diffuseRightColor, opacityParts, reflectionLeftColor, reflectionRightColor, emissiveLeftColor, emissiveRightColor, refractionLeftColor, refractionRightColor, vReflectionPosition, vReflectionSize, logarithmicDepthConstant, vTangentSpaceParams, alphaCutOff, vLightData0, vLightDiffuse0, vLightSpecular0, vLightDirection0, vLightGround0, lightMatrix0, shadowsInfo0, depthValues0, diffuseSampler, ambientSampler, opacitySampler, reflectionCubeSampler, reflection2DSampler, emissiveSampler, specularSampler, bumpSampler, lightmapSampler, refractionCubeSampler, refraction2DSampler, shadowSampler0, depthSampler0 BJS - [23:19:35]: Attributes: position, normal BJS - [23:19:35]: Error: unknown #version type: 300 es BJS - [23:19:35]: Trying next fallback. BJS - [23:19:35]: Unable to compile effect: BJS - [23:19:35]: Uniforms: world, view, viewProjection, vEyePosition, vLightsType, vAmbientColor, vDiffuseColor, vSpecularColor, vEmissiveColor, vFogInfos, vFogColor, pointSize, vDiffuseInfos, vAmbientInfos, vOpacityInfos, vReflectionInfos, vEmissiveInfos, vSpecularInfos, vBumpInfos, vLightmapInfos, vRefractionInfos, mBones, vClipPlane, diffuseMatrix, ambientMatrix, opacityMatrix, reflectionMatrix, emissiveMatrix, specularMatrix, bumpMatrix, normalMatrix, lightmapMatrix, refractionMatrix, diffuseLeftColor, diffuseRightColor, opacityParts, reflectionLeftColor, reflectionRightColor, emissiveLeftColor, emissiveRightColor, refractionLeftColor, refractionRightColor, vReflectionPosition, vReflectionSize, logarithmicDepthConstant, vTangentSpaceParams, alphaCutOff, vLightData0, vLightDiffuse0, vLightSpecular0, vLightDirection0, vLightGround0, lightMatrix0, shadowsInfo0, depthValues0, diffuseSampler, ambientSampler, opacitySampler, reflectionCubeSampler, reflection2DSampler, emissiveSampler, specularSampler, bumpSampler, lightmapSampler, refractionCubeSampler, refraction2DSampler, shadowSampler0, depthSampler0 BJS - [23:19:35]: Attributes: position, normal BJS - [23:19:35]: Error: unknown #version type: 300 es

Invalid produced shader: https://exokit.slack.com/files/U90GZV4GN/FBUMQB3EH/broken_shader.txt

[TrevorDev]

@modulesio Thanks so much, will do.

I might be able to dig a bit more into webmixedreality/exokit#283 to see where/when in babylon the viewport is somehow setting the wrong values when I get some free time.

[avaer]

I got http://www.babylonjs-playground.com/frame.htm#EIX8SD#7 working by fixing bugs https://github.com/webmixedreality/exokit/pull/282 + https://github.com/webmixedreality/exokit/pull/281.

I filed https://github.com/webmixedreality/exokit/issues/283 to track the too small viewport calls coming from Babylon.js. I’ll have to understand the Babylon architecture more, but the setViewport() calls are using the old canvas size to set gl.viewport, resulting in a too small render.

Regarding Reality Tabs, it is Ctrl-1 to enter VR but we still need to document many of these features on https://docs.webmr.io/.

@TrevorDev Finally, if I missed something re: Exokit, could you file an issue at the Exokit repo?