SceneOptimizer: "Positions are required"

Bugs

App works fine if not using SceneOptimizer.

When activating SceneOptimizer, I get an error “Positions are required”, which is coming from this file: https://github.com/BabylonJS/Babylon.js/blob/a0afb803db41aa578c8adb04971cca4848765a54/src/Mesh/babylon.mesh.vertexData.ts#L466

Whether I do:

public async createScene(): Promise<void> {
  this.scene = new Scene(this.engine);

  this.optimizeScene();
}

private optimizeScene() {
  const optimizationSettings = SceneOptimizerOptions.ModerateDegradationAllowed();
  optimizationSettings.targetFrameRate = 30;

  SceneOptimizer.OptimizeAsync(
    this.scene,
    optimizationSettings,
    () => { ... },
    () => { ... },
  );
}

Or:

public async createScene(): Promise<void> {
  this.scene = new Scene(this.engine);

  this.scene.whenReadyAsync().then(
    () => this.optimizeScene()
  )
}

private optimizeScene() {
  const optimizationSettings = SceneOptimizerOptions.ModerateDegradationAllowed();
  optimizationSettings.targetFrameRate = 30;

  SceneOptimizer.OptimizeAsync(
    this.scene,
    optimizationSettings,
    () => { ... },
    () => { ... },
  );
}

I get the error.

Not 100% sure that’s a bug, I might be missing something but as it’s perfectly working when I do not use the SceneOptimizer I’m suspicious.

[zakhenry]

@deltakosh I managed to get a repro at last. Unfortunately I can’t save it in the playground as I’m getting a 500 error?

Here’s the code anyway:

var createScene = function () {

    // This creates a basic Babylon Scene object (non-mesh)
    var scene = new BABYLON.Scene(engine);

    // This creates and positions a free camera (non-mesh)
    var camera = new BABYLON.FreeCamera("camera1", new BABYLON.Vector3(0, 5, -10), scene);

    // This targets the camera to scene origin
    camera.setTarget(BABYLON.Vector3.Zero());

    // This attaches the camera to the canvas
    camera.attachControl(canvas, true);

    // This creates a light, aiming 0,1,0 - to the sky (non-mesh)
    var light = new BABYLON.HemisphericLight("light1", new BABYLON.Vector3(0, 1, 0), scene);

    // Default intensity is 1. Let's dim the light a small amount
    light.intensity = 0.7;

    // Our built-in 'sphere' shape. Params: name, subdivs, size, scene
    var sphere = BABYLON.Mesh.CreateSphere("sphere1", 16, 2, scene);
    var sphere2 = BABYLON.Mesh.CreateSphere("sphere2", 12, 1.5, scene);
    var sphere3 = BABYLON.Mesh.CreateSphere("sphere2", 8, 1, scene);

    sphere.position.y = 1;
    sphere2.position.y = 2;
    sphere3.position.y = 3;

    // Our built-in 'ground' shape. Params: name, width, depth, subdivs, scene
    var ground = BABYLON.Mesh.CreateGround("ground1", 6, 6, 2, scene);

    const optimizationSettings = BABYLON.SceneOptimizerOptions.ModerateDegradationAllowed();
    optimizationSettings.targetFrameRate = 70;

    sphere2.parent = sphere;
    sphere3.parent = sphere2;

    BABYLON.SceneOptimizer.OptimizeAsync(
        this.scene,
        optimizationSettings,
        () => { 
            console.log("done")
        },
        () => { 
            console.log("failed")
        },
    );

    return scene;

};

[deltakosh]

Ok no worry…I’ll check back early july then 😃