Culture code
See original GitHub issueFirst of all, I don’t want to offend anyone. I’m really very grateful for such great lib, it helped us to solve a lot of problems. Thanks!
I do understand that probably this issue won’t change anything, since it’s, obviously, too late, and seems to be in accordance with numbro’s team visions.
But anyway, my two cents.
Why it has been decided to rely on culture
term? In most part of i18n community used term locale (probably, thanks to GNU efforts).
I’m working as Translation Coordinator and i18ning some apps for about year or two, but never heard about culture code
before. Obviously, I’ve probably came across it somewhere, since I’ve often used Microsoft tables with locale codes. But since locale
term was so popular till that time I’ve never realized that Microsoft actually used culture code
instead of locale
.
I think it would be logical to use culture code
if numbro was somehow related to Microsoft’s products, but it isn’t that case, and in Node community it isn’t well know term, since all popular i18n libs operate with term locale
:
- https://github.com/SlexAxton/Jed
- https://github.com/andris9/node-gettext
- https://github.com/SlexAxton/messageformat.js
- http://i18next.com/
- http://l20n.org/
From my personal point of view, Microsoft invented culture
as result of fatal flaw of locale
term, despite everywhere in i18n community were used locale
or language code
terms, and its naming very confusing, since has nothing to do with culture. It consists of {language code}
and {region code
}. Does it represent any culture, which can be many in specified `{lang-Region}? Obviously no.
Issue Analytics
- State:
- Created 8 years ago
- Comments:14 (5 by maintainers)
Top GitHub Comments
I will try to do a clean up and use
locale
everywhere as it’s more GNU-ish thanculture
😄Hello,
I’m a bit late to this discussion, but it seems like the concensus is that
locale
andculture
should be synonyms in the code? In that case, should these deprecation warnings be removed?e.g. https://github.com/foretagsplatsen/numbro/blob/b2c22217448d714f1548a55cedab6ba546bfae1c/dist/numbro.js#L742 https://github.com/foretagsplatsen/numbro/blob/b2c22217448d714f1548a55cedab6ba546bfae1c/dist/numbro.js#L789
there are many other examples. Should the
culture
methods & properties be made true aliases?