Improve flexibility and consistency of cell plottingSee original GitHub issue
ATM for plotting cells one would need to pass a pandas dataframe with the x,y,z columns, or a list of column names specifying col 1,2, and 3.
- The first option should be replaced for consistency with column names
- The second option is quite redundant syntax-wise, and should be replaced with just supporting a
(n_cells, 3)shape numpy array (so that the user can just invoke
add_cells(df[[col1, col2, col3]].values)
can make a PR fir this in the next days! But this will potentially break some code for the users, exp @adamltyson . Should probably go through a deprecation phase.
- Created 3 years ago
- Comments:8 (4 by maintainers)
Top GitHub Comments
Yes, will do after Friday!
Regarding passing a numpy array, the reason why it’s the way it is at the moment is that users can pass a df and use another column as metadata for coloring.
I think this is useful but I would just point users in the docstring to how to label the columns for this to work!
Addressed in brainrender 2.0