reviewing examples
See original GitHub issueHi, first off ,thanks for using vtkplotter
! 😃
I went through the examples and I found a bunch of possible problems:
in Example/Cells.ipynb
in Misc.ipynb no slider is shoowing in the rendering window (this might be due to my local version of vtkplotter, I might have broken some functionality…)
In Regions.ipynb: Also update_folder doesn’t seem to exist…
In Video.ipynb i get:
Besides, I have a few suggestions to maybe improve the interface i.e.
- can add rendering window titles with
Plotter(title='BrainRender version x.x')
- consider Plotter shape descriptors “1|3”, “3|1”, “2/3”, this is a new feature that allows to subdivide rendering spaces asymmetrically.
- can set position of the Scene / Plotter instance with Plotter(pos=(x_screen,y_screen)` when having multiple windows
- Some examples take quite a long to download + render, maybe it is a good idea to indicate in the example the approx time for the user to wait or use a
ProgressBar
- the iconized whole brain (very nice idea btw!) shows up a bit too high in the rendering window
- add some method to close window (maybe a button with status color, or
a scene.close()
method). I;m not sure if there is the possibility to disable ‘q’ on keyboard as this hangs the execution… - Neuron.ipynb takes ages to load a nr of neurons… maybe could be made faster by reducing the amount of stuff to download, or is it expected or necessary at all?
- Consider not rendering the empty Scene() when creating the instance, as probably it is not necessary…
ignore any of these which you consider irrelevant or let me know if you need clarifications or help 😃 Cheers Marco
Issue Analytics
- State:
- Created 4 years ago
- Comments:8 (2 by maintainers)
Top Results From Across the Web
Positive Reviews Examples: Copy and Paste Ideas
Positive reviews examples: copy and paste ideas that businesses can use to collect positive reviews and improve customer satisfaction.
Read more >9 customer review examples + template for getting more reviews
Customer reviews are the engine that keeps prospects coming. Get helpful examples and free outreach templates for getting more reviews!
Read more >Positive review examples: It's all in the response - Birdeye
In this guide, we'll walk you through what makes a good review, why positive reviews are important, how to respond to positive reviews,...
Read more >10 Powerful Customer Review Examples & How to Ask for More
Ten great customer review examples; How to get more customer reviews; How to ask for customer reviews; How to respond to reviews; How...
Read more >Review Examples - Writing Samples - AcademicHelp.net
It takes on a different tone, format, and style compared to academic writing. Look at our review samples to get better acquainted with...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Hi Marco, sorry to bother you again.
Could you have a look at https://github.com/BrancoLab/BrainRender/issues/18#issue-536468176 when you have a moment?
It seems that when multiple scenes are created one after the other, the actors are upside down from the second scene onwards. I don’t think that this has anything to do with brain render per se, but I can’t tell what’s causing this either. If you could look into it that would be awesome, as the current fix for it is suboptimal.
Hi Marco,
The errors in the examples should be fixed now. Thank you again for spotting them and reporting them!
Cheers, Fede