a-c table not being updated correctly

Description

Updating from 0.58.18 to 0.58.20 appears to keep the Auto Contribute table intact. However, once you start visiting sites, you’ll notice that the a-c table isn’t being updated properly. For example, the first site you visit which meets criteria to be added to the table (regardless of whether it was already in the table previously), is listed at 100%. If you visit a site that was already in the table, you will see two listings for that site. It seems like your already existing sites (prior to update) don’t appear to be taken into account - it’s like you started with a completely clean table.

Steps to Reproduce

1. Have a profile with rewards data from 0.58.18.
2. Update to 0.58.20 (I can only update on test channel, so I swapped the .app files on mac)
3. Launch 0.58.20 and open brave://rewards page. You will see that your a-c table looks intact.
4. Visit a site that isn’t already in the table so that it meets minimum criteria.
5. Go back to brave://rewards.
6. Site is listed first at 100% and already existing sites remain displayed in table

Actual result:

When you continue to visit sites, some already in table and some not, you will see that your % values don’t add up. Your already existing sites (prior to update) don’t appear to be taken into account - it’s like you started with a completely clean table. Below I visited a site which was already in the table. You’ll see that it gets added a second time:

Expected result:

Existing sites should not be ignored and should be taken into account for table entries and % values

Reproduces how often:

easily

Brave version (brave://version info)

Brave	0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision	15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS	Mac OS X

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
• Is the issue reproducible on the latest version of Chrome?

Additional Information

cc @brave/legacy_qa for verification on other platforms cc @rebron @NejcZdovc @mandar-brave

[NejcZdovc]

@GeetaSarvadnya steps looks good to me

[GeetaSarvadnya]

Verified the issue on Windows 10 x64 - Followed below steps

1. Clean profile 0.58.20
2. Add two sites to A-C table (for my test I have added brianbony.com and nytimes)
3. Close the browser and set the Month and year as Dec 2018 for both sites ( I have set this date in publishers_info_db)

1. Upgrade the profile with 0.58.21
2. Add new site to A-C table (Added CNN.com)
3. Viewed A-C table (% values added up to 100% for 3 sites)
4. Visit the site which is already added to A-C table in 0.58.20 (in my tc I have added brianbondy.com again in 0.58.21)
5. Viewed A-C table (% values added up to 100% for 3 sites, there is no duplicate entry in ac table)

Publisher_info_db:

@NejcZdovc Can you verify the steps and let me know is this the correct way to test this defect. @LaurenWags can you please verify steps and let me know if i have missed anything.