warning not being displayed the first time around when clicking on `Confirm Sync Code` without any code added
See original GitHub issueDescription
When clicking on Confirm Sync Code
under Enter a sync code
, the entire modal will get closed without any warnings. When you open the Enter a sync code
modal again, you’ll get the warning from the previous failure.
Steps to Reproduce
- launch brave (
0.59.20 Chromium: 72.0.3626.28
in this instance) - open
brave://sync
and click onI Have a Sync Code
- click on
Confirm Sync Code
without adding anything into the text field - you’ll notice that the entire modal is closed right away without any warnings
- click on
I Have a Sync Code
and you’ll receive the warning that should have appeared in the first place
Actual result:
Expected result:
Should be warning the user that the import failed rather than closing the modal and than warning the user once they go into the Enter a sync code
for a second time.
Reproduces how often:
100% reproducible using the above STR.
Brave version (brave://version info)
Brave | 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta(64-bit) |
---|---|
Revision | 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461} |
OS | Mac OS X |
Reproducible on current release:
- Does it reproduce on brave-browser dev/beta builds?
Reproducible on beta
and assuming it’s also reproducible on dev
as well as the new UI would have been merged into dev
first.
Issue Analytics
- State:
- Created 5 years ago
- Comments:5 (2 by maintainers)
Top Results From Across the Web
Confirm Sync Code Button is Non-Responsive
Description Follow up of #2845 Warning message not being displayed, when click on Confirm Sync code without any code added. steps to ...
Read more >Errors and warnings during Sync - AppSheet Help
This warning may signify that the add, update, or delete is taking a long time to process.
Read more >Directory synchronization to Azure Active Directory stops or ...
Describes a performance problem in Azure Active Directory Sync Tool. The tool either stops syncing or reports that sync hasn't run in more ......
Read more >Automatically fill in verification codes on iPhone - Apple Support
Passwords are the first authentication factor, and temporary, one-time verification codes are commonly a second factor. iPhone can automatically generate ...
Read more >Visual Studio Code Workspace Trust security
Visual Studio Code takes security seriously and wants to help you safely browse and edit code no matter the source or original authors....
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Same thing happens if you enter an invalid sync code. STR:
0.59.20 Chromium: 72.0.3626.28
in this instance)brave://sync
and click onI Have a Sync Code
Confirm Sync Code
I Have a Sync Code
and you’ll receive the warning that should have appeared in the first placeVerification passed on
Used test plan from https://github.com/brave/brave-core/pull/1357 and from https://github.com/brave/brave-browser/issues/2845#issuecomment-452372326
Verification PASSED on
macOS 10.14.2
using the following build:Verification passed on Ubuntu 17.10