"Always request desktop website" feature no longer works on numerous websites.

Description

A lot of sites serve mobile version, while Desktop mode is enabled globally for all sites ( Settings -> Site settings -> Desktop Mode). For sites which load mobile version Desktop mode checkbox is active (three vertical dots in lower right corner -> desktop mode) meaning Desktop veersion should be served, but that`s not happening.

Affected websites include, but not limited to 4pda.ru ; rbc.ru ; android.stackexchange.com (SE subdomains not the original site)

Hiding Brave to background and reopening works as one-time remedy for the page. Also switching Desktop mode via page checkbox (three vertical dots in lower right corner -> desktop mode) off and on makes correct version to be served (desktop version).

Steps to reproduce

1. Enable serve Desktop globally for all sites ( Settings -> Site settings -> Desktop Mode)
2. Create new empty tab
3. Type one of the affected websites URL (4pda.ru for example)
4. Mobile version is served initially

Actual result

Before temporal remedy (minimizing\maximizing Brave or reloading Desktop mode)

After temporal remedy (minimizing\maximizing Brave or reloading Desktop mode)

Expected result

Site should be opened in desktop mode right away without need for additonal actions.

Issue reproduces how often

Issue reproduced every time for affected websites

Issue happens on

Google Play latest version

Device details

Testes on two ARM phones: Android 8.0.0 Lg v30+ Android 9 Oneplus 7 Pro

Brave version

Latest Brave 1.2.0 Chromium 76.0.3809.111 (but the bug has beed around for a while)

Website problems only

Issue persists with shileds turned off. Chrome lacks always desktop mode feature.

Additional info:

Related bug: https://github.com/brave/browser-android-tabs/issues/740 This bug is related, but different in a sense that issue 740 depicts case when sites dont open Desktop version at all and my ticket raises situation when Brave is capable of opening Desktop verson and does so but only after additional external input.

Related ticket: https://github.com/brave/browser-android-tabs/issues/124

[kirilloffs]

@deeppandya, seems the reason for this bug is simple: sites detect screen resolution (discover that screen proportion is mobile phone proportion) and forcefully serve mobile version despite desktop user agent preset active.

So the fix should be rather simple - while sending fake desktop user agent, also to send fakescreen resolution info to correspond to that of a desktop screen proportions.

@SergeyZhukovsky @srirambv @LaurenWags @anthonypkeane may be it worth reopening ticket https://github.com/brave/browser-android-tabs/issues/124 as it in fact https://github.com/brave/browser-android-tabs/issues/124 no longer passes QA checks 3 and 5 stated in that ?

[samartnik]

This has been fixed in the context of https://github.com/brave/brave-browser/issues/20963