question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Click `Add funds` in the panel is redirecting to brave settings page when Brave rewards is turned OFF

See original GitHub issue

Description

Click Add funds in the panel is redirecting to brave settings page when Brave rewards is turned OFF

Steps to Reproduce

  1. Clean profile 0.69.114
  2. Join rewards
  3. Turn OFF brave rewards
  4. Click on BR panel
  5. Click on Add funds in BR panel
  6. Add funds redirected to brave rewards settings page

Actual result:

Click Add funds in the panel is redirecting to brave settings page when Brave rewards is turned OFF image

Expected result:

make it behave as it behaves in the brave rewards settings page

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.69.114 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Windows 10 OS Version 1803 (Build 17134.523)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@brave/legacy_qa @NejcZdovc @mandar-brave

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:7 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
NejcZdovccommented, Oct 15, 2019

@LaurenWags 3631 will go into 0.70

0reactions
GeetaSarvadnyacommented, Oct 21, 2019

Verification passed on

Brave 0.70.118 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the STR from the description (verified both clean and upgraded profile)
  • Verified the test plan from https://github.com/brave/brave-core/pull/3631
  • Verified the below when Brave rewards switch is OFF
    • Click on Add funds in BR panel is redirecting to ADD FUNDS page in Uphold, If the brave wallet is connected to uphold account
    • Click on Add funds in Settings page is redirecting to ADD FUNDS page in Uphold, If the brave wallet is connected to uphold account
    • Click on Add funds in BR panel is redirecting to Verify wallet modal if the brave wallet is NOT connected to uphold account
    • Click on Add funds in settings page is redirecting to Verify wallet modal if the brave wallet is NOT connected to uphold account

Verification passed on

Brave 0.70.118 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Ubuntu 18.04 LTS
  • Verified the STR from the description (verified both clean and upgraded profile)
  • Verified the test plan from https://github.com/brave/brave-core/pull/3631
  • Verified the below when Brave rewards switch is OFF
    • Click on Add funds in BR panel is redirecting to ADD FUNDS page in Uphold, If the brave wallet is connected to uphold account
    • Click on Add funds in Settings page is redirecting to ADD FUNDS page in Uphold, If the brave wallet is connected to uphold account
    • Click on Add funds in BR panel is redirecting to Verify wallet modal if the brave wallet is NOT connected to uphold account
    • Click on Add funds in settings page is redirecting to Verify wallet modal if the brave wallet is NOT connected to uphold account

Verified passed with

Brave 0.70.119 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified the STR from the description (verified both clean and upgraded profile)
  • Verified the test plan from https://github.com/brave/brave-core/pull/3631
  • Verified the below when Brave rewards switch is OFF
    • Click on Add funds in BR panel is redirecting to ADD FUNDS page in Uphold, If the brave wallet is connected to uphold account
    • Click on Add funds in Settings page is redirecting to ADD FUNDS page in Uphold, If the brave wallet is connected to uphold account
    • Click on Add funds in BR panel is redirecting to Verify wallet modal if the brave wallet is NOT connected to uphold account
    • Click on Add funds in settings page is redirecting to Verify wallet modal if the brave wallet is NOT connected to uphold account
Read more comments on GitHub >

github_iconTop Results From Across the Web

Resetting Brave Rewards
By resetting your Brave Rewards profile, you will delete all the Brave Rewards data on your device, and will start again as though...
Read more >
Can not disable Brave Ads
Brave Rewards are disabled. Open Rewards panel to enable and get started; Show Brave Rewards icon in address bar. The add popups still...
Read more >
How do I use Brave Rewards?
Use the Rewards Settings page (brave://rewards) to fine-tune your ... Clicking the toggle located in the Rewards drop-down panel while on ...
Read more >
Brave Browser Privacy Policy
You can disable Ads by visiting Settings > Brave Rewards > Ads and turning off the Ads default. In the cases where we...
Read more >
Brave Release Notes
(#24990); Added the ability to disable Brave Wallet via Admin policy. ... Re-enabled “Side panel” display setting under brave://settings/appearance.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found