Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`Block scripts` heading label should read `Blocked scripts`

See original GitHub issue

Description

Steps to Reproduce

install 1.39.65
launch Brave
load cnn.com
click on the Shields icon in the URL bar
click Advanced controls
click to toggle Block scripts to ON
click on the blurple number to the right of Block scripts

Actual result:

10 Block scripts

Expected result:

10 Blocked scripts

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.39.65 Chromium: 101.0.4951.34 (Official Build) nightly (x86_64)
Revision	8f93af5d759634c5256b65997dedd138ed60992f-refs/branch-heads/4951@{#710}
OS	macOS Version 11.6.5 (Build 20G527)

cc @nullhook @rmcfadden3 @jenn-rhim @MadhaviSeelam @GeetaSarvadnya

Issue Analytics

State:
Created a year ago
Comments:5

Top GitHub Comments

1reaction

rmcfadden3commented, Jun 16, 2022

Will defer to @stephendonner on this one, but now that I see it in context, I wonder if this should actually read “XX scripts blocked”

(note no capitalization on the “s” or “b” and also ordering of words reversed)

0reactions

stephendonnercommented, Jun 23, 2022

Will defer to @stephendonner on this one, but now that I see it in context, I wonder if this should actually read “XX scripts blocked”

(note no capitalization on the “s” or “b” and also ordering of words reversed)

Sounds good to me; I’ll file a followup issue and cross-reference here, for posterity 👍 (We should re-evaluate grammar and punctuation for the other categories, while we’re at it.)

Top Results From Across the Web

Block Third-Party Scripts with a Few Lines of Javascript

Disclaimer: This article is about blocking scripts that are known to be safe, like analytics — meaning scripts from third party services ...

Blocking versus Non blocking scripts - Packt Hub

In this article we saw the basics of blocking versus non blocking scripts. We saw how the async attribute allows the browser to...

Article: Preventing Auto-Blocking from Blocking Scripts

To prevent Auto-Blocking from blocking the script, you will need to add the argument data-ot-ignore to the script segment. This will make Auto-Blocking...

Cross-Origin Read Blocking (CORB)

Cross-Origin Read Blocking (CORB). This document outlines Cross-Origin Read Blocking (CORB), an algorithm by which dubious cross-origin resource loads may ...

The Script element - HTML: HyperText Markup Language

This Boolean attribute is set to indicate that the script should not be ... Blocking rendering till a script is fetched and executed....