Shields panel doesn't always update immediately upon light/dark-mode toggle
See original GitHub issueDescription
Shields panel doesn’t always update immediately upon light/dark-mode toggle
Steps to Reproduce
- install
1.39.68
- launch Brave
- load
twitch.tv
- click on the Shields icon in the URL bar
- in a new tab, open
brave://settings/appearance
- if
Light
, chooseDark
, and vice-versa - in the
twitch.tv
tab, click again on the Shields icon in the URL bar
Actual result:
Expected result:
The Shields panel should observe pref changes to Light
/ Dark
and re-validate its cache
Reproduces how often:
100%
Brave version (brave://version info)
Brave | 1.39.68 Chromium: 101.0.4951.34 (Official Build) nightly (x86_64) |
---|---|
Revision | 8f93af5d759634c5256b65997dedd138ed60992f-refs/branch-heads/4951@{#710} |
OS | macOS Version 12.4 (Build 21F5048e) |
Issue Analytics
- State:
- Created a year ago
- Comments:6 (1 by maintainers)
Top Results From Across the Web
Task Manager Light/Dark Mode Bug - Microsoft Community
To do this, right click or long press on the desktop, select "Personalize", select "Colors", and then select either "Dark" or "Light" for...
Read more >Reduce eye strain on your Galaxy phone or tablet - Samsung
First, swipe down from the top of the screen with two fingers to open the Quick settings panel. Then, touch and hold the...
Read more >How to enable dark mode on your phone, laptop, and more
Click “Display,” then toggle “Dark theme” on. Alternatively, you can pull down from the top of the display to reveal the Quick Settings,...
Read more >How to Get Snapchat Dark Mode in Android and iOS
Scroll down the Settings menu and tap App Appearance. 3. Select the option labeled Always Dark. Snapchat will instantly switch from Light Mode ......
Read more >Implementing Dark Mode In React Apps Using styled ...
Dark mode is the color scheme of any interface that displays light text and interface elements on a dark background, which makes the...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
This happens because shields bubble is destroyed after some delay. After some times passed(don’t know the exact timing…), shields bubble will have proper theme color. @nullhook Do you think shiels panel can monitor theme change and use it?
Verified
PASSED
using