question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Shields panel doesn't always update immediately upon light/dark-mode toggle

See original GitHub issue

Description

Shields panel doesn’t always update immediately upon light/dark-mode toggle

Steps to Reproduce

  1. install 1.39.68
  2. launch Brave
  3. load twitch.tv
  4. click on the Shields icon in the URL bar
  5. in a new tab, open brave://settings/appearance
  6. if Light, choose Dark, and vice-versa
  7. in the twitch.tv tab, click again on the Shields icon in the URL bar

Actual result:

Screen Shot 2022-04-18 at 8 13 20 PM

Expected result:

The Shields panel should observe pref changes to Light / Dark and re-validate its cache

Screen Shot 2022-04-18 at 8 14 55 PM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.39.68 Chromium: 101.0.4951.34 (Official Build) nightly (x86_64)
Revision 8f93af5d759634c5256b65997dedd138ed60992f-refs/branch-heads/4951@{#710}
OS macOS Version 12.4 (Build 21F5048e)

cc @nullhook @rebron @MadhaviSeelam @GeetaSarvadnya

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:6 (1 by maintainers)

github_iconTop GitHub Comments

1reaction
simonhongcommented, Apr 22, 2022

This happens because shields bubble is destroyed after some delay. After some times passed(don’t know the exact timing…), shields bubble will have proper theme color. @nullhook Do you think shiels panel can monitor theme change and use it?

0reactions
stephendonnercommented, Jun 23, 2022

Verified PASSED using

Brave 1.41.77 Chromium: 103.0.5060.53 (Official Build) beta (64-bit)
Revision a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS Linux
example example example
Screen Shot 2022-06-23 at 3 03 06 PM Screen Shot 2022-06-23 at 3 03 14 PM Screen Shot 2022-06-23 at 3 03 19 PM
Read more comments on GitHub >

github_iconTop Results From Across the Web

Task Manager Light/Dark Mode Bug - Microsoft Community
To do this, right click or long press on the desktop, select "Personalize", select "Colors", and then select either "Dark" or "Light" for...
Read more >
Reduce eye strain on your Galaxy phone or tablet - Samsung
First, swipe down from the top of the screen with two fingers to open the Quick settings panel. Then, touch and hold the...
Read more >
How to enable dark mode on your phone, laptop, and more
Click “Display,” then toggle “Dark theme” on. Alternatively, you can pull down from the top of the display to reveal the Quick Settings,...
Read more >
How to Get Snapchat Dark Mode in Android and iOS
Scroll down the Settings menu and tap App Appearance. 3. Select the option labeled Always Dark. Snapchat will instantly switch from Light Mode ......
Read more >
Implementing Dark Mode In React Apps Using styled ...
Dark mode is the color scheme of any interface that displays light text and interface elements on a dark background, which makes the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found