question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Brave asks "Do you want to leave?" when actually the server is just triggering a download, not leaving the site.

See original GitHub issue

Description

This happens in Google Drive (yes… the irony…), when I choose a whole folder and click “Download”, Drive packs it as a .zip, when it’s done, it sends some signal to the browser to trigger the download. Then, Brave shows the same confirmation you see when you are leaving a site with unsaved data (I think its the onbeforeunload event).

The most annoying of this is that the prompt appears in whatever tab you are currently, and the first times I thought: “…what’s going on?!”, not associating this prompt with the download from Drive

Steps to Reproduce

  1. Go to Google Drive
  2. Right click on a folder
  3. Download
  4. Wait there, or move to a different tab / window
  5. When Brave asks “Do you want to leave the site?”, say yes, and the download will trigger normally

Actual result:

Shows a confirm prompt

Expected result:

Just trigger the download / ask me where to save the download, with no “Leave site” confirm

Reproduces how often:

Always

Brave version (brave://version info)

Brave | 0.62.51 Chromium: 73.0.3683.103 (Build oficial) (64 bits)

e82a658d8159cabbd4938c1660f9bb00b4a82a23-refs/branch-heads/3683@{#902}

on Ubuntu 18.10 (installed via .deb file)

Reproducible on current release:

I don’t know

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?

Nope

  • Is the issue reproducible on the latest version of Chrome?

Surely not. I switched to Brave a few days ago and this never happened on Chrome.

Additional Information

Nothing to add

Issue Analytics

  • State:open
  • Created 4 years ago
  • Reactions:3
  • Comments:8 (1 by maintainers)

github_iconTop GitHub Comments

1reaction
tinchocommented, Apr 12, 2019

Hi there! Thanks for the screenshots (I didn’t include them as they would be in spanish)

The bug is not “I can’t download” but rather “confirmation message is annoying, and wrong”. Because we are not leaving the site, just downloading a file while still on the site. If the folder is large and Drive takes some time preparing it, the user may have focused on another tab and when the message appears, will confuse to the user, if not aware of this bug, he won’t know which site is it talking about.

0reactions
robocraxcommented, Aug 8, 2020

Can confirm this is happening with Chrome 84.0.4147.105 (Official Build) (64-bit) on Windows 10 1909

Read more comments on GitHub >

github_iconTop Results From Across the Web

Why do I have to choose "Keep" every time I download ...
Expected behavior: You click download a file, and it downloads. When does it happen: Always without the option to customize. Versions: macOS 10.14.6,...
Read more >
Downloads to NAS stopped working in last update - file does ...
Description of the issue: Downloading files (eg PDFs using Fireshot Image Capture extension) works as it should if you select a local folder ......
Read more >
Auto closing when downloading anything - Brave Community
When I go to download any file from any site it comes up with the box to choose where to save and then...
Read more >
How do I fix file download errors? - Brave Help Center
This error means you don't have permission to download this file from the server. To fix, go to the website where the file...
Read more >
Brave will not download files - Browser Support
Brave used to save files as .pdf with no problem. Recently I save as I have done before. The file name is created...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found