Brave asks "Do you want to leave?" when actually the server is just triggering a download, not leaving the site.
See original GitHub issueDescription
This happens in Google Drive (yes… the irony…), when I choose a whole folder and click “Download”, Drive packs it as a .zip, when it’s done, it sends some signal to the browser to trigger the download.
Then, Brave shows the same confirmation you see when you are leaving a site with unsaved data (I think its the onbeforeunload
event).
The most annoying of this is that the prompt appears in whatever tab you are currently, and the first times I thought: “…what’s going on?!”, not associating this prompt with the download from Drive
Steps to Reproduce
- Go to Google Drive
- Right click on a folder
- Download
- Wait there, or move to a different tab / window
- When Brave asks “Do you want to leave the site?”, say yes, and the download will trigger normally
Actual result:
Shows a confirm prompt
Expected result:
Just trigger the download / ask me where to save the download, with no “Leave site” confirm
Reproduces how often:
Always
Brave version (brave://version info)
Brave | 0.62.51 Chromium: 73.0.3683.103 (Build oficial) (64 bits)
e82a658d8159cabbd4938c1660f9bb00b4a82a23-refs/branch-heads/3683@{#902}
on Ubuntu 18.10 (installed via .deb file)
Reproducible on current release:
I don’t know
Website problems only:
- Does the issue resolve itself when disabling Brave Shields?
Nope
- Is the issue reproducible on the latest version of Chrome?
Surely not. I switched to Brave a few days ago and this never happened on Chrome.
Additional Information
Nothing to add
Issue Analytics
- State:
- Created 4 years ago
- Reactions:3
- Comments:8 (1 by maintainers)
Top GitHub Comments
Hi there! Thanks for the screenshots (I didn’t include them as they would be in spanish)
The bug is not “I can’t download” but rather “confirmation message is annoying, and wrong”. Because we are not leaving the site, just downloading a file while still on the site. If the folder is large and Drive takes some time preparing it, the user may have focused on another tab and when the message appears, will confuse to the user, if not aware of this bug, he won’t know which site is it talking about.
Can confirm this is happening with Chrome 84.0.4147.105 (Official Build) (64-bit) on Windows 10 1909