Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Confirmation type `dismiss` is not recorded in confirmations.json file

See original GitHub issue

Description

When we tap Close in ads notification popup, the confirmation type event dismiss is not recorded in the confirmations.json file.

Steps to Reproduce

Clean profile 0.63.31
Enable rewards
Open brave.com or imdb.com
Keep the page idle for 15 secs
Move the cursor
Tap on Close in Ads notification popup
Navigate to profile folder rewards_service and open confirmations.json file

Actual result:

confirmation type dismiss is not recorded in confirmations.json file

Expected result:

confirmation type dismiss should be recorded in the confirmations.json file

Reproduces how often:

Always

Brave version (brave://version info)

Brave	0.63.31 Chromium: 73.0.3683.75 (Official Build) beta (64-bit)
Revision	909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS	Windows 10 OS Build 17134.523

Reproducible on current release: No

Does it reproduce on brave-browser dev/beta builds? Yes

Website problems only:

Does the issue resolve itself when disabling Brave Shields? NA
Is the issue reproducible on the latest version of Chrome? NA

Additional Information

@brave/legacy_qa

Issue Analytics

State:
Created 4 years ago
Comments:7 (2 by maintainers)

Top GitHub Comments

1reaction

srirambvcommented, Apr 5, 2019

[22828:22828:0405/075417.693148:INFO:confirmations_impl.cc(642)] Saving confirmations state
[22828:22828:0405/075417.694175:INFO:confirmations_impl.cc(782)] Removed 68148e86-7ff0-4e3c-bafb-3157bd01d062 creative instance id for dismiss from the confirmation queue
[22828:22828:0405/075417.694194:INFO:confirmations_impl.cc(642)] Saving confirmations state
[22828:22828:0405/075417.695120:INFO:redeem_token.cc(424)] Successfully redeemed token with 68148e86-7ff0-4e3c-bafb-3157bd01d062 creative instance id for dismiss
[22828:22828:0405/075417.695186:INFO:confirmations_impl.cc(931)] No failed confirmations to retry

Just rechecked and there is successful confirmation of the same token being redeemed

0reactions

GeetaSarvadnyacommented, Jan 21, 2020

@terry Issue is reproducible only in 0.63.x. In the latest versions issue is fixed and working fine. Verified a couple of releases 1.1.x and 1.2.x and 1.3.x. Hence closing the issue.

Top Results From Across the Web

Check any data after confirmation message using JSON

I think problem in your php file. your JOSN data is not in correct ... header('Content-Type: application/json'); echo json_encode($array);.

Signing up and confirming user accounts - Amazon Cognito

When users enter the confirmation code, they automatically verify email or phone. A user account can be in any of the following states:...

5. Transactions - Mastering Bitcoin [Book] - O'Reilly

Once recorded on the blockchain and confirmed by sufficient subsequent blocks (confirmations), the transaction is a permanent part of the bitcoin ledger and ......

How to get the transaction confirmations using the JSON RPC

When you send a transaction, you will receive back a transaction hash. Use the command getTransactionByHash({transaction hash}) to retrieve ...

Verify Android App Links - Android Developers

Associating a website with multiple apps; Associating multiple websites with a single app; Publishing the JSON verification file.