Bug: ipfs:// drops query and hash parts

To reproduce have IPFS enabled and local node is running.

#fragment

• enter ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html#Emerging_artist via address bar
  • 💔 it loads, but does not jump to #Emerging_artist header, and the fragment is also removed from address bar

This makes it impossible for people to link to specific sections of documents

?query=params

• ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/I/m/Vincent_van_Gogh_-_Self-Portrait_-_Google_Art_Project_(454045).jpg?filename=test.jpg&download=true
  • 💔 query parameters are not forwarded to the gateway, which in turns produces gateway response missing Content-Disposition header

This makes it impossible to create a link which triggers download instead of having file rendered in browser.

@autonome @bbondy I think we want to fix both, but lmk if there is a reason to keep current behavior.

[yrliou]

With https://github.com/brave/brave-core/pull/7693, we won’t drop query parameters anymore, but currently we get Content-Disposition: inline; filename*=UTF-8''test.jpg instead of attachment for ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/I/m/Vincent_van_Gogh_-Self-Portrait-Google_Art_Project(454045).jpg?filename=test.jpg&download=true, so brave won’t open a download dialog but only renders it in the browser. This is because https://github.com/ipfs/go-ipfs/pull/7677 is merged after go-ipfs 0.7.0 release which brave is currently using.

[stephendonner]

👋🏼 @stephendonner 😁

Small 🌎 ; fancy meeting you here! Brought a smile to my face to know another awesome Mozillian was “at the other end.” ❤️