Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Wrong time on New Tab Page

See original GitHub issue

Test plan

(taken from https://bugs.chromium.org/p/chromium/issues/detail?id=1168528#c48 and modified)

Change windows time zone to some time zone where can exists summer timer time, for instance, (America/Santiago).

Open a tab and then open the developer tools
In the console paste in the following and hit enter: Intl.DateTimeFormat().resolvedOptions().timeZone
- In Chrome 88 it shows: America/Santiago

Disable `Automatic change DST` option on Windows (America/Santiago).

Open a tab and then open the developer tools
In the console paste in the following and hit enter: Intl.DateTimeFormat().resolvedOptions().timeZone
- In Chromium 88 WITHOUT the fix it shows: Etc/GMT-4
- In Chromium 88 WITH the fix it should show Etc/GMT+4

Description

Time of brave is different from current time

Steps to Reproduce

it just happens, i did nothing to reproduce it

Actual result:

Hkc3pwrFvx

as you can see, the time on brave is different from my system time

Expected result:

both times to be the same

Brave version (info found on brave://version)

Brave	1.19.86 Chromium: 88.0.4324.96 (Official Build) (64-bit)
Revision	68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS	Windows 10 OS Version 2004 (Build 19041.746)
JavaScript	V8 8.8.278.14
User Agent	Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.96 Safari/537.36

Issue Analytics

State:
Created 3 years ago
Reactions:1
Comments:12 (7 by maintainers)

Top GitHub Comments

1reaction

GeetaSarvadnyacommented, Feb 3, 2021

Verification passed on


Brave | 1.19.90 Chromium: 88.0.4324.146 (Official Build) (64-bit)
-- | --
Revision | 406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS | Windows 10 OS Version 2004 (Build 19041.746)

Verified the test plan from the description

Reproduced the issue in 1.19.86 Chromium: 88.0.4324.96

NTP clock is different from system time

Upgraded profile to 1.19.90 Chromium: 88.0.4324.146 and ensured Time in NTP is displayed same as system time

12- hours clock

24 - hour clock

Verified passed with

Brave	1.19.90 Chromium: 88.0.4324.146 (Official Build) (64-bit)
Revision	406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS	Windows 10 OS Version 1909 (Build 18363.1256)

Using 1.19.88 Chromium: 88.0.4324.96, confirmed time works correctly when “Adjust for daylight saving time automatically” is enabled: Screen Shot 2021-02-03 at 7 57 29 AM

Using 1.19.88 Chromium: 88.0.4324.96, reproduced the issue when “Adjust for daylight saving time automatically” is not enabled:

Example	Example

Using 1.19.90 Chromium: 88.0.4324.146, confirmed time works correctly when “Adjust for daylight saving time automatically” is enabled: Screen Shot 2021-02-03 at 8 13 32 AM

Using 1.19.90 Chromium: 88.0.4324.146, confirmed time works correctly when “Adjust for daylight saving time automatically” is not enabled:

Example	Example

Verified passed with

Brave	1.19.90 Chromium: 88.0.4324.146 (Official Build) (32-bit)
Revision	406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS	Windows 10 OS Version 2009 (Build 19042.685)

Using 1.19.88 Chromium: 88.0.4324.96, confirmed time works correctly when “Adjust for daylight saving time automatically” is enabled: Screen Shot 2021-02-03 at 8 29 10 AM

Using 1.19.88 Chromium: 88.0.4324.96, reproduced the issue when “Adjust for daylight saving time automatically” is not enabled:

Example	Example

Using 1.19.90 Chromium: 88.0.4324.146, confirmed time works correctly when “Adjust for daylight saving time automatically” is enabled: Screen Shot 2021-02-03 at 8 35 18 AM