Can't enable Ads while offline, from brave://rewards page
See original GitHub issueDescription
Can’t enable Ads while offline, from brave://rewards page
Steps to Reproduce
- new profile
- launch Brave
- disconnect from Wi-Fi/internet
- load
brave://settings
- click on
Brave Rewards
in the left pane - click on the right pane to enable
Brave Private Ads
- click
Skip for now
- click
Continue
- click
Done
- dismiss the panel
- load
brave://rewards
- try to toggle
Ads
toOn
Actual result:
Expected result:
Should be able to enable Ads
, as you can from brave://settings
, while offline
Reproduces how often:
100%
Brave version (brave://version info)
Brave | 1.33.51 Chromium: 95.0.4638.69 (Official Build) nightly (64-bit) |
---|---|
Revision | 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984} |
OS | Linux |
Issue Analytics
- State:
- Created 2 years ago
- Comments:12 (4 by maintainers)
Top Results From Across the Web
FAQ: Why am I not seeing Brave Ads? - Brave Community
You can enable Brave Rewards by navigating to brave://Rewards in your browser. Here on the Rewards Settings page, you will see the option...
Read more >Can't turn on Ads - Mobile Support - Brave Community
Select “Settings” in popup. From “chrome://rewards” turn on (deactivate off) “Ads.”
Read more >No more ads and verification error - Brave Community
Go to brave://rewards-internals and click on Logs; Open the Rewards panel and disconnect your browser wallet from Uphold. Once disconnected go ...
Read more >How do I opt-in to Brave Ads?
Ads will be turned on by default when Brave Rewards is first enabled. You may turn Ads on or off at any time...
Read more >Can not disable Brave Ads
Hello community,. Brave rewards are disabled on my device. Opening the Brave Rewards tab does (brave://settings/rewards) not show me the ...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
I have seen inconsistencies with Chromium detecting Windows network connections.
I see how this works now. It seems that you can actually enable Ads when you don’t have an Internet connection, it’s just that you have to have already created a wallet before disabling your network connection. In my test, I successfully enabled Ads with my network disconnected because I already had a wallet. So there’s really no explicit code in Ads to do this, it just sort of happens due to the way things are structured. In fact, when you try to enable Ads with the network disconnected and no wallet the screen flickers because it’s trying to turn Ads on, but the wallet creation fails and it goes back to disabled again.
It honestly seems to me like we should be more intentional in our handling of this. Having an Ads toggle button that stops working without warning when the Internet isn’t connected seems like it will frustrate/confuse users. It also doesn’t cover the (probably common) case of a user enabling Rewards/Ads and then losing internet connectivity (unless I’m missing something…)