[Sync] Devices reappear after removing from the sync chain

Description

Issue reported by @iefremov

May be related to https://bugs.chromium.org/p/chromium/issues/detail?id=1225961

Basically I add a device to the existing chain, then remove and it reappears after a while - sometimes immediately, sometimes after 1-3 minutes.
Tried one more time: removed a phone from the chain on desktop browser. After ~10 minutes phone is not shown on the chain on desktop (which is good), but the browser on the phone itself is synced, shows the whole chain on the settings page.

Steps to Reproduce

1. Create a sync chain between two desktop profiles
2. From deviceA remove deviceB
3. Wait ~3 minutes

Actual result:

1. deviceB disappears from the devices list at deviceA, but then re-appears
2. deviceB never goes into sync is turned off state

Expected result:

1. deviceB disappears from the devices list at deviceA, and then doesn’t re-appear
2. deviceB goes into sync is turned off state

Reproduces how often:

Easily reproduced

Desktop Brave version:

Confirmed at

Brave	1.33.77 Chromium: 96.0.4664.35 (Official Build) unknown (64-bit)
Revision	8df3babf8da8faa8aacb78f4848ef66a93b4944b-refs/branch-heads/4664@{#680}

Android Device details:

• Install type (ARM, x86):
• Device type (Phone, Tablet, Phablet):
• Android version:

Version/Channel Information:

• Can you reproduce this issue with the current release?
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @jsecretan , @darkdh

[btlechowski]

Verification passed on

Brave	1.34.71 Chromium: 97.0.4692.56 (Official Build) beta (64-bit)
Revision	04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS	Ubuntu 18.04 LTS

and the same version for Android; iOS is 1.34 (21.12.21.19)

Linux --> iOS - PASSED

1. new profile of 1.34.x on Linux
2. launch Brave
3. set up a Sync chain
4. join Sync chain from iOS by scanning the QR code
5. from desktop, click on the trashcan icon to remove the iOS device
6. click OK when prompted to confirm
7. wait 3 minutes
8. look at the Sync screen on Linux
9. look at the Sync screen on iOS

Confirmed the Linux desktop remains Confirmed the iOS device is removed

Linux --> Android - PASSED

1. new profile of 1.34.x on Linux
2. launch Brave
3. set up a Sync chain
4. join Sync chain from Android by scanning the QR code
5. from desktop, click on the trashcan icon to remove the Android device
6. click OK when prompted to confirm
7. wait 3 minutes
8. look at the Sync screen on Linux
9. look at the Sync screen on Android

Confirmed the Linux desktop remains Confirmed the Android device is removed

iOS --> Linux - PASSED

1. fresh install Brave for iOS 1.34.x
2. tap through onboarding
3. tap on the 3-dots icon on the bottom right of the toolbar
4. tap Settings
5. tap Sync
6. tap Start a new sync chain
7. tap Add a computer
8. copy the code words
9. on Linux, launch Brave 1.34.x
10. load brave://settings/braveSync
11. click on Start using sync
12. click I have a Sync Code
13. paste the code words and click Confirm
14. click OK
15. tap on the Linux device on iOS
16. tap Remove device
17. tap Remove
18. wait 3 minutes
19. look at the Sync screen on iOS
20. look at the Sync screen on Linux

Confirmed the iOS device remains Confirmed the Linux desktop is removed

Android --> Linux - PASSED

1. fresh install Brave for Android 1.34.x
2. tap through onboarding
3. tap on the 3-dots icon on the bottom right of the toolbar
4. tap Settings
5. tap Sync
6. tap Start a new sync chain
7. tap Add a computer
8. copy the code words
9. on Linux, launch Brave 1.34.x
10. load brave://settings/braveSync
11. click on Start using sync
12. click I have a Sync Code
13. paste the code words and click Confirm
14. click OK
15. click on the trashcan icon to remove Linux
16. wait 3 minutes
17. look at the Sync screen on Android
18. look at the Sync screen on Linux

Confirmed the Android device remains Confirmed the Linux desktop is removed

Linux --> Windows, iOS, and Android - PASSED

1. new profile of 1.34.x on Windows
2. launch Brave
3. click on Start a new sync chain
4. click on Phone/Tablet
5. join Sync chain from iOS
6. join Sync chain from Android
7. join Sync chain from Windows
8. from Linux, click on the trashcan icons to remove the Windows, iOS, & Android devices
9. click OK when prompted to confirm
10. wait 3 minutes
11. look at the Sync screen on Linux
12. look at the Sync screen on Windows
13. look at the Sync screen on iOS
14. look at the Sync screen on Android

Confirmed the Linux desktop remains Confirmed the Windows desktop is removed Confirmed the iOS device is removed Confirmed the Android device is removed

---

Verification passed on Brave v1.34.73 on Samsung Galaxy Tab S5e (Android 10.0)

Linux --> Android Tab - PASSED

1. new profile of 1.34.x on Linux
2. launch Brave
3. set up a Sync chain
4. join Sync chain from Android by scanning the QR code
5. from desktop, click on the trashcan icon to remove the Android device
6. click OK when prompted to confirm
7. wait 3 minutes
8. look at the Sync screen on Linux
9. look at the Sync screen on Android

Confirmed the Linux desktop remains Confirmed the Android device is removed

Android Tab --> Linux - PASSED

1. fresh install Brave for Android 1.34.x
2. tap through onboarding
3. tap on the 3-dots icon on the bottom right of the toolbar
4. tap Settings
5. tap Sync
6. tap Start a new sync chain
7. tap Add a computer
8. copy the code words
9. on Linux, launch Brave 1.34.x
10. load brave://settings/braveSync
11. click on Start using sync
12. click I have a Sync Code
13. paste the code words and click Confirm
14. click OK
15. click on the trashcan icon to remove Linux
16. wait 3 minutes
17. look at the Sync screen on Android
18. look at the Sync screen on Linux

Confirmed the Android device remains Confirmed the Linux desktop is removed

|| | –|–|–|–

[LaurenWags]

@brave/legacy_qa check leaving a sync chain with various devices/platforms