crash can occur when clicking on the rewards icon (particularly if BAP popup is displayed)
See original GitHub issueDescription
Found while testing https://github.com/brave/brave-core/pull/7698
Sometimes tapping on the rewards icon in the URL bar crashes the browser. I’ve only encountered it so far when the BAP popup is overlapping the rewards panel (https://github.com/brave/brave-browser/issues/14108).
Steps to Reproduce
- Clean profile, region = Japan, staging environment
- Opened NTP
- Opened Rewards panel, dismissed onboarding modal
- Claimed UGP grant
- Completed captcha
- Waited a few seconds (for grant to process), then closed “It’s your lucky day” overlay.
- Clicked elsewhere so Brave was not in focus
- Then the BAP popup displayed overlapping the rewards panel
- Click on the rewards icon in the URL bar
Actual result:
Brave crashes, crash report ID: 42120000-f138-da05-0000-000000000000
Expected result:
No crash, I believe without the BAP popup clicking on that icon would close the rewards panel
Reproduces how often:
easily
Brave version (brave://version info)
Brave 1.22.19 Chromium: 89.0.4389.40 (Official Build) nightly (x86_64)
Revision 2c2ed83cd507b23e4845edd09a7d1dfc727daf4b-refs/branch-heads/4389@{#602}
OS macOS Version 10.15.7 (Build 19H512)
Version/Channel Information:
- Can you reproduce this issue with the current release?
- Can you reproduce this issue with the beta channel?
- Can you reproduce this issue with the nightly channel? yes
Other Additional Information:
- Does the issue resolve itself when disabling Brave Shields?
- Does the issue resolve itself when disabling Brave Rewards?
- Is the issue reproducible on the latest version of Chrome?
Miscellaneous Information:
Issue Analytics
- State:
- Created 3 years ago
- Comments:6 (4 by maintainers)
Top Results From Across the Web
Tipping doesn't do anything · Issue #2106 · brave/brave-browser ...
crash can occur when clicking on the rewards icon (particularly if BAP popup is displayed) #14110. Closed. BAP cutoff date isn't correctly detected...
Read more >Where can I edit my Custom Reward Points Popup Modal?
When this button is clicked, the visitor will see a popup modal that offers them various enticements to earn bonus reward points. The...
Read more >Yet Another Mechlab at MechWarrior 5: Mercenaries Nexus - Mods ...
Fully unlocked, MWO-style Mechlab with all missing MWO Mech variants and weapon and AMS hardpoints. Supports vanilla savegames and mech mods.
Read more >-Patch Notes- Archival (v278.73 & Below) :: ARK: Survival Evolved ...
Fixed an issue where the Mini Map Marker wouldn't display correctly in certain areas of the game. - Slightly decreased Rex's ability to...
Read more >the 2 of 3 and 4 0 5 to 6 a 7 in 8 1 9 for 10 image 11 2 12 is 13
the 2 of 3 and 4 0 5 to 6 a 7 in 8 1 9 for 10 image 11 2 12 is...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
As per https://github.com/brave/internal/issues/747#issuecomment-761233483, the tooltip won’t be appearing as we’re basically ~2 days before March 13th hits. As per the specification, the tooltip stops appearing a week before March 13th. So a lot of the above cases aren’t valid anymore re: using the tooltip.
Verification PASSED on
Win 10 x64
using the following build:rewards
icon once you’ve claimed the grant doesn’t crash Braverewards
icon when the warning modal is opened via the NTP doesn’t crash Braverewards
icon when March 13th hits and balance appears as0.00
doesn’t crash BraveVerified passed with
rewards
icon once you’ve claimed the grant doesn’t crash Braverewards
icon when the warning modal is opened via the NTP doesn’t crash Braverewards
icon when March 13th hits and balance appears as0.00
doesn’t crash BraveVerification passed on
rewards
icon once you’ve claimed the grant doesn’t crash Braverewards
icon when the warning modal is opened via the NTP doesn’t crash Braverewards
icon when March 13th hits and balance appears as0.00
doesn’t crash Brave