Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

BAP cutoff date isn't correctly detected

See original GitHub issue

Description

Found while testing https://github.com/brave/brave-browser/issues/13701 / https://github.com/brave/brave-core/pull/7698

Unable to claim staging UGP grant when in Japan region.

Steps to Reproduce

Clean profile on Nightly w/ region = Japan and staging env
Click on Rewards icon and enable Rewards
No UGP grant.

Actual result:

No UGP grant is offered. See the below in logs:

[7846:775:0210/113532.139689:VERBOSE1:promotion.cc(113)] Fetch promotions disabled for BAP migration

Expected result:

Since date has not been met, UGP grant should be available

Reproduces how often:

easily

Brave version (brave://version info)

Brave	1.22.16 Chromium: 89.0.4389.40 (Official Build) nightly (x86_64)
Revision	2c2ed83cd507b23e4845edd09a7d1dfc727daf4b-refs/branch-heads/4389@{#602}
OS	macOS Version 10.15.7 (Build 19H512)

Version/Channel Information:

Can you reproduce this issue with the current release? n/a
Can you reproduce this issue with the beta channel? n/a
Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields?
Does the issue resolve itself when disabling Brave Rewards?
Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @brave/legacy_qa @zenparsing @Miyayes

Issue Analytics

State:
Created 3 years ago
Comments:6 (6 by maintainers)

Top GitHub Comments

2reactions

kjozwiakcommented, Feb 12, 2021

Going to need to recheck this quickly we uplift it into 1.21.x 👍 Removing QA Pass-macOS so it doesn’t get missed.

0reactions

srirambvcommented, Mar 11, 2021

Verification passed on OnePlus 6T with Android 10 running 1.21.76 x64 build

Verified able to claim grant for Locale US

   [ RESPONSE - OnRequest ]
    > Url: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828/claims/c8a0d23e-0e5b-45f2-a554-546bb2172dd6
    > Result: Success
    > HTTP Code: 200

Verified able to claim grant for Locale Japanese

[ RESPONSE - OnRequest ]
    > Url: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828
    > Result: Success
    > HTTP Code: 200
    > Body: {"claimId":"2e61f61e-d4f4-400b-90d1-e3ab18c3b50a"}
2021-03-11 08:09:05.280 20957-20957/? V/chromium: [VERBOSE5:ledger_impl.cc(133)] 
    [ REQUEST ]
    > URL: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828/claims/2e61f61e-d4f4-400b-90d1-e3ab18c3b50a
    > Method: UrlMethod::GET
2021-03-11 08:09:05.543 20957-20957/? V/chromium: [VERBOSE6:logging_util.cc(136)] 
    [ RESPONSE - OnRequest ]
    > Url: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828/claims/2e61f61e-d4f4-400b-90d1-e3ab18c3b50a
    > Result: Success
    > HTTP Code: 200

Verification passed on Samsung Tab A with Android 10 running 1.21.76 x64 build

Verified able to claim grant for Locale US

 2021-03-11 09:02:51.970 12229-12229/? V/chromium: [VERBOSE6:logging_util.cc(136)] 
    [ RESPONSE - OnRequest ]
    > Url: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828
    > Result: Success
    > HTTP Code: 200
    > Body: {"claimId":"7ab39fa5-0518-41f3-a0ce-c2a726b6a4b9"}
2021-03-11 09:02:52.009 12229-12229/? V/chromium: [VERBOSE5:ledger_impl.cc(133)] 
    [ REQUEST ]
    > URL: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828/claims/7ab39fa5-0518-41f3-a0ce-c2a726b6a4b9
    > Method: UrlMethod::GET
2021-03-11 09:02:52.296 12229-12229/? V/chromium: [VERBOSE6:logging_util.cc(136)] 
    [ RESPONSE - OnRequest ]
    > Url: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828/claims/7ab39fa5-0518-41f3-a0ce-c2a726b6a4b9
    > Result: Success
    > HTTP Code: 200

Verified able to claim grant for Japanese Locale

2021-03-11 08:48:33.906 6514-6514/? V/chromium: [VERBOSE6:logging_util.cc(136)] 
    [ RESPONSE - OnRequest ]
    > Url: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828
    > Result: Success
    > HTTP Code: 200
    > Body: {"claimId":"df77bc65-f5b2-47dd-9ab2-848ed02f2221"}
2021-03-11 08:48:33.932 6514-6514/? V/chromium: [VERBOSE5:ledger_impl.cc(133)] 
    [ REQUEST ]
    > URL: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828/claims/df77bc65-f5b2-47dd-9ab2-848ed02f2221
    > Method: UrlMethod::GET
2021-03-11 08:48:34.209 6514-6514/? V/chromium: [VERBOSE6:logging_util.cc(136)] 
    [ RESPONSE - OnRequest ]
    > Url: https://grant.rewards.bravesoftware.com/v1/promotions/962abffd-4952-40cd-b90d-05868e233828/claims/df77bc65-f5b2-47dd-9ab2-848ed02f2221
    > Result: Success
    > HTTP Code: 200

Top Results From Across the Web

Bug: rsvp cutoff date is not stored correctly in single ticket mode

This problem occurs with EM 5.9.10, but older versions are affected too. When Single ticket mode is active the rsvp cutoff date for...

BinaryAnalysisPlatform/bap - Gitter

So, I have a primus analysis (using the KB), the only task of which is to load and save from the KB into...

Appeals Before The Bankruptcy Appellate Panel Of The Ninth ...

BAP. 1999), the BAP held that the 30-day deadline begins to run on the date of the court's transmission of the notice of...

Petitioning Process to Establish a Chapter of Beta Alpha Psi

The petitioning chapter must generally complete four semesters (six quarters) of successfully reported activities to be installed as a BAP Chapter.

Guidelines for BAP Standards

BAP requires compliance because it recognizes that not all governmental agencies have sufficient resources to effectively enforce laws. Processing plants can ...