question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

crash prompt dialog has both rounded and square corners - follow up to #1841

See original GitHub issue

Description

Crash prompt was added with https://github.com/brave/brave-browser/issues/1841

On macOS Catalina this crash prompt dialog looks odd, it has both rounded and square corners:

Screen Shot 2021-08-27 at 8 24 02 AM

Looking at the verification notes under https://github.com/brave/brave-browser/issues/1841#issuecomment-891359676, the prompt looks ok with macOS 12.0, but Windows and Linux behave the same as Catalina having both rounded and squared corners on this prompt.

Steps to Reproduce

Follow test plan for https://github.com/brave/brave-browser/issues/1841 or:

  1. Clean profile 1.29.x
  2. Open Guest window
  3. Go to brave://settings
  4. Click on Rewards at the top of the settings page
  5. Brave crashes (known issue, logged with https://github.com/brave/brave-browser/issues/15053)
  6. Relaunch Brave
  7. Get crash report prompt

Actual result:

Light Dark
Screen Shot 2021-08-27 at 8 41 11 AM Screen Shot 2021-08-27 at 8 24 02 AM

Expected result:

Rounded or squared corners on the prompt, not both

Reproduces how often:

Easily

Brave version (brave://version info)

Brave | 1.29.74 Chromium: 93.0.4577.58 (Official Build) (x86_64)
-- | --
Revision | c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS | macOS Version 10.15.7 (Build 19H1323)

Version/Channel Information:

  • Can you reproduce this issue with the current release? 1.28.x n/a, but 1.29.x yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @brave/legacy_qa @rebron @simonhong

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:5 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
LaurenWagscommented, Sep 9, 2021

Verified passed on macOS x64 10.15.7 (Catalina) with

Brave | 1.31.12 Chromium: 93.0.4577.58 (Official Build) nightly (x86_64)
-- | --
Revision | c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS | macOS Version 10.15.7 (Build 19H1323)

Verified test plan from https://github.com/brave/brave-core/pull/9894#issue-722053375 Confirmed no rounded corners on the prompt

Screen Shot 2021-09-01 at 2 36 14 PM

Verified PASSED on

Brave 1.31.18 Chromium: 93.0.4577.63 (Official Build) nightly (64-bit)
Revision ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS Linux

Verified test plan from https://github.com/brave/brave-core/pull/9894#issue-722053375 Confirmed no rounded corners on the prompt

Screen Shot 2021-09-03 at 6 37 09 PM

Verified PASSED on

Brave 1.31.31 Chromium: 93.0.4577.63 (Official Build) nightly (64-bit)
Revision ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS Windows 10 OS Version 2009 (Build 22000.176)

Verified test plan from https://github.com/brave/brave-core/pull/9894#issue-722053375 Confirmed no rounded corners on the prompt

crash-dialog

0reactions
User198263321commented, Nov 8, 2021

Would be nice if this could be changed with a flag.

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to make custom dialog with rounded corners in android
What is happening: I am able to make custom dialog but it doesn't have rounded corners. I tried adding a selector but still...
Read more >
Rounded Corners Over Sharp Corners | by Andrea Perera
In the context of this topic, I've analyzed several posts that offer a comparison between Curved and Sharp Corners UI elements. In most...
Read more >
border-radius - CSS: Cascading Style Sheets - MDN Web Docs
The border-radius CSS property rounds the corners of an element's outer border edge. You can set a single radius to make circular corners, ......
Read more >
Why Rounded Corners Are Easier on the Eyes - UX Movement
Some experts say that rectangles with rounded corners are easier on the eyes than a rectangle with sharp edges because they take less...
Read more >
lake city fl shooting today
One officer and a Florida Highway Patrol trooper were both in the area. ... a teen is dead following a shooting Tuesday evening...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found