crash prompt dialog has both rounded and square corners - follow up to #1841
See original GitHub issueDescription
Crash prompt was added with https://github.com/brave/brave-browser/issues/1841
On macOS Catalina this crash prompt dialog looks odd, it has both rounded and square corners:
Looking at the verification notes under https://github.com/brave/brave-browser/issues/1841#issuecomment-891359676, the prompt looks ok with macOS 12.0, but Windows and Linux behave the same as Catalina having both rounded and squared corners on this prompt.
Steps to Reproduce
Follow test plan for https://github.com/brave/brave-browser/issues/1841 or:
- Clean profile 1.29.x
- Open Guest window
- Go to brave://settings
- Click on Rewards at the top of the settings page
- Brave crashes (known issue, logged with https://github.com/brave/brave-browser/issues/15053)
- Relaunch Brave
- Get crash report prompt
Actual result:
Light | Dark |
---|---|
Expected result:
Rounded or squared corners on the prompt, not both
Reproduces how often:
Easily
Brave version (brave://version info)
Brave | 1.29.74 Chromium: 93.0.4577.58 (Official Build) (x86_64)
-- | --
Revision | c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS | macOS Version 10.15.7 (Build 19H1323)
Version/Channel Information:
- Can you reproduce this issue with the current release? 1.28.x n/a, but 1.29.x yes
- Can you reproduce this issue with the beta channel? yes
- Can you reproduce this issue with the nightly channel? yes
Other Additional Information:
- Does the issue resolve itself when disabling Brave Shields?
- Does the issue resolve itself when disabling Brave Rewards?
- Is the issue reproducible on the latest version of Chrome?
Miscellaneous Information:
Issue Analytics
- State:
- Created 2 years ago
- Comments:5 (4 by maintainers)
Top Results From Across the Web
How to make custom dialog with rounded corners in android
What is happening: I am able to make custom dialog but it doesn't have rounded corners. I tried adding a selector but still...
Read more >Rounded Corners Over Sharp Corners | by Andrea Perera
In the context of this topic, I've analyzed several posts that offer a comparison between Curved and Sharp Corners UI elements. In most...
Read more >border-radius - CSS: Cascading Style Sheets - MDN Web Docs
The border-radius CSS property rounds the corners of an element's outer border edge. You can set a single radius to make circular corners, ......
Read more >Why Rounded Corners Are Easier on the Eyes - UX Movement
Some experts say that rectangles with rounded corners are easier on the eyes than a rectangle with sharp edges because they take less...
Read more >lake city fl shooting today
One officer and a Florida Highway Patrol trooper were both in the area. ... a teen is dead following a shooting Tuesday evening...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Verified passed on
macOS x64 10.15.7
(Catalina) withVerified test plan from https://github.com/brave/brave-core/pull/9894#issue-722053375 Confirmed no rounded corners on the prompt
Verified
PASSED
onVerified test plan from https://github.com/brave/brave-core/pull/9894#issue-722053375 Confirmed no rounded corners on the prompt
Verified
PASSED
onVerified test plan from https://github.com/brave/brave-core/pull/9894#issue-722053375 Confirmed no rounded corners on the prompt
Would be nice if this could be changed with a flag.