Custom adblock rules should allow cosmetic filters
See original GitHub issueTest plan
See https://github.com/brave/brave-core/pull/4700
Description
Custom adblock rules doesn’t work
Steps to Reproduce
- Install 0.64.x build
- Add a custom rule for a site in
brave://adblock
- Visit the page for which the custom rule was added, doesn’t block [Detailed STR on https://github.com/brave/brave-core/pull/3121]
Actual result:
Custom adblock rule doesn’t work. Element is still loaded after adding the rule
Expected result:
Should block elements based on custom rule
Reproduces how often:
Easy
Brave version (brave://version info)
Brave | 0.64.72 Chromium: 74.0.3729.131 (Official Build) beta(64-bit) |
---|---|
Revision | 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954} |
OS | Linux |
Version/Channel Information:
- Can you reproduce this issue with the current release? N/A
- Can you reproduce this issue with the beta channel? Yes
- Can you reproduce this issue with the dev channel? Yes
- Can you reproduce this issue with the nightly channel? Yes
Other Additional Information:
- Does the issue resolve itself when disabling Brave Shields? N/A
- Does the issue resolve itself when disabling Brave Rewards? N/A
- Is the issue reproducible on the latest version of Chrome? N/A
Miscellaneous Information:
Context menu CSS blocker works fine but isn’t always blocking the right element. This didnt work on muon as well https://github.com/brave/browser-laptop/issues/12308 cc: @emerick
Issue Analytics
- State:
- Created 4 years ago
- Reactions:4
- Comments:17 (12 by maintainers)
Top Results From Across the Web
How to create your own ad filters - AdGuard Knowledgebase
At the same time, AdGuard allows you to create your own custom filters using the same types of rules that we have in...
Read more >Adblock Plus filters explained
Exception rules are built the same as blocking rules, they define which addresses should be allowed even if matching blocking rules exists.
Read more >How to use custom filters - AdBlock
Click the AdBlock icon on your browser's toolbar, then the gear symbol on the dropdown menu. On the options menu, select the Customize...
Read more >Cosmetic filters of custom filter lists - Ad-Blocking
Since Manifest v3 comes soon and Brave's Ad-Blocker feature is unaffected I'm currently trying it out. Sadly I just found out that the...
Read more >Show HN: Let's Block It – Custom uBlock Origin Filters Made ...
Yandex is one company that's known to put effort into resisting ad blockers—to the point that uBlock/AdBlock filter authors had to just give...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
I don’t think this issue was actually addressed with https://github.com/brave/brave-core/pull/3121
This issue is covering the brave://adblock page and being able to add cosmetic filters there; the PR was updating functionality in the right click menu
Re-opening and removing milestone
+1 also encountering this