question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

DApps: Address the security concern to show eTLD+1 of max 255 characters (site+domain) and show site origin in Panels

See original GitHub issue

Description

Steps to reproduce

  1. Create a DApp wallet connectivity request with lengthy eTLD+1
  2. A eTLD+1 with 255 chars (max) is not bold and origin is not displayed

Actual result

A eTLD+1 is not bold in DApps permission panel and origin is not displayed

Expected result

Issue reproduces how often

Not yet merged in master

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? NA
  • Can you reproduce this issue with the current Play Store Nightly version? NA

Additional information

Also add/replace the root view with ScrollView for lengthy values.

cc: @diracdeltas

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:5 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
Pavneet-Singcommented, Mar 21, 2022

Got it, then length of 255 character will not be a concern on Android without scroll. Possible UI adaption could be is to show a warning or something, when the length exceeds then we can make the whole screen scroll able and keep the whole domain and subdomain sections visible (instead of defining a specific height of the domain and subdomain section).

0reactions
srirambvcommented, Jun 16, 2022

Verification passed on Oppo Reno 5 with Android 12 running 1.40.101

Connect Account Approve Tx Approve Network Switch Network Sign Message Encryption message
image image image image image image

Verification passed on Samsung Tab A with Android 10 running 1.40.101

Connect Account Approve Network Switch Network Connected State Sign Message Encryption message
image image image image image image
Read more comments on GitHub >

github_iconTop Results From Across the Web

No pagebuilder available after update - WordPress.org
Hi Siteorigin-Team, I upgrade php 7.4 to 8.0, wordpress from 5.5 to 6.1 and all plugins too (pagebuilder from 2.4.25 to 2.19.0).
Read more >
Almost a year with the same problem! Please help. - SiteOrigin
So, I created the footer section using this plugin and your Page Builder, but for some reason isn't rendering the columns and rows...
Read more >
WordPress Plugins and Themes with Known Issues
Solution: Uncheck Enable 404 fallbacks in the Autoptimize settings page wp-admin/options-general.php?page=autoptimize . The Pantheon Platform ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found