DApps: Address the security concern to show eTLD+1 of max 255 characters (site+domain) and show site origin in Panels
See original GitHub issueDescription
- Update the android implementation and UI for eTLD+1 (site+domain) in
brave_permission_dialoglayout and delegate as per eTLD+1 standards. The 255 chars limit should have no issue but verify it with real data [-done]. Make sure the discussed details are being shown. - Show origin on all request panels, equivalent to desktop issue https://github.com/brave/brave-browser/issues/21904 or iOS https://github.com/brave/brave-ios/issues/5188
Steps to reproduce
- Create a DApp wallet connectivity request with lengthy eTLD+1
- A eTLD+1 with 255 chars (max) is not bold and origin is not displayed
Actual result
A eTLD+1 is not bold in DApps permission panel and origin is not displayed
Expected result
- Show eTLD+1 should be bold and completely visible
- Origin info should be displayed
Issue reproduces how often
Not yet merged in master
Version/Channel Information:
- Can you reproduce this issue with the current Play Store version? NA
- Can you reproduce this issue with the current Play Store Beta version? NA
- Can you reproduce this issue with the current Play Store Nightly version? NA
Additional information
Also add/replace the root view with ScrollView for lengthy values.
cc: @diracdeltas
Issue Analytics
- State:
- Created 2 years ago
- Comments:5 (4 by maintainers)
Top Results From Across the Web
No pagebuilder available after update - WordPress.org
Hi Siteorigin-Team, I upgrade php 7.4 to 8.0, wordpress from 5.5 to 6.1 and all plugins too (pagebuilder from 2.4.25 to 2.19.0).
Read more >Almost a year with the same problem! Please help. - SiteOrigin
So, I created the footer section using this plugin and your Page Builder, but for some reason isn't rendering the columns and rows...
Read more >WordPress Plugins and Themes with Known Issues
Solution: Uncheck Enable 404 fallbacks in the Autoptimize settings page wp-admin/options-general.php?page=autoptimize . The Pantheon Platform ...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found

Got it, then length of 255 character will not be a concern on Android without scroll. Possible UI adaption could be is to show a warning or something, when the length exceeds then we can make the whole screen scroll able and keep the whole domain and subdomain sections visible (instead of defining a specific height of the domain and subdomain section).
Verification passed on Oppo Reno 5 with Android 12 running 1.40.101
Verification passed on Samsung Tab A with Android 10 running 1.40.101