Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

The toggle of `Auto-redirect AMP pages` is visible inside other pages at `brave://settings/privacy`

See original GitHub issue

Description

The toggle of the new Auto-redirect AMP pages feature is currently visible in all other pages at the brave://settings/privacy section.

Steps to Reproduce

Install Brave Nightly.
Open brave://settings/privacy.
Open either of the following pages: Cookies and other site data, Security, Site and Shields Settings (the toggle will be visible in all site settings pages too).
Take a look at the right corner of the newly opened page, where the search functionality is located.

Actual result:

actual

Clicking on the toggle will enable/disable Auto-redirect AMP pages feature at brave://settings/privacy.

Expected result:

expected

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.38.57 Chromium: 99.0.4844.74 (Official Build) nightly (64-bit)
Revision	fee9a47e86e981802390cb0d41c5ed7ea93c4f6f-refs/branch-heads/4844@{#1060}
OS	Windows 7 Service Pack 1 (Build 7601)

</body> </html>

Version/Channel Information:

Can you reproduce this issue with the current release? No
Can you reproduce this issue with the beta channel? No
Can you reproduce this issue with the nightly channel? Yes

Miscellaneous Information:

CC: @ShivanKaul

Issue Analytics

State:
Created 2 years ago
Reactions:1
Comments:6 (5 by maintainers)

Top GitHub Comments

1reaction

stephendonnercommented, Mar 28, 2022

Verified PASSED using

Brave	1.38.70 Chromium: 100.0.4896.46 (Official Build) beta (x86_64)
Revision	5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS	macOS Version 11.6.5 (Build 20G527)

Confirmed Auto-redirect AMP pages toggle is in the right place, and works Confirmed no more rogue De-amp pref entries

`Settings`	`Cookies and other site data`	`Security`	`Site and Shields Settings`

1reaction

kjozwiakcommented, Mar 24, 2022

@kjozwiak

Excuse me for the off-topic, but I have to ask since I’m not aware - is it already time for Auto-redirect AMP pages to be translated in other languages? The current issue is about the feature so I would like to know if I should open a follow up issue regarding my question. Thank you 👍

Believe we’ll get translations for the above once we start doing translations for 1.38.x but I could be wrong. CCing @mkarolin @rebron who know a more about the translation process.

Top Results From Across the Web

What is Brave's "De-AMP" feature?

To toggle this feature, you can go to brave://settings/shields and click Auto-redirect AMP pages . Still have Questions? If you would like to ......

How to "De-AMP" the Web With Privacy-Focused Browser Brave

Open Brave. · Select the three-dot menu button in the bottom-right of your screen. · Tap Settings to access the settings menu. ·...

Brave Browser to Begin Bypassing AMP Pages by Default

Beta & Nightly builds of Brave Browser now automatically redirect AMP websites to the full version unless you disable the toggle in the ......

Brave's latest feature automatically bypasses Google AMP ...

Brave announced in a blog post that it's rolling out a new “De-AMP” feature that automatically bypasses Google's Accelerate Mobile Pages (AMP) ...

Brave's De-AMP feature redirects Google-hosted AMP pages ...

With De-AMP enabled, Brave attempts to parse links directly to redirect the loading to the publisher's website immediately; this is the case for ......