question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Remove extra spacing from clear browsing data bubble for PT/Tor windows

See original GitHub issue

Description

After removing the images from the clear browsing data bubble for PT/Tor windows via https://github.com/brave/brave-core/pull/12643, you’ll notice that there’s some extra space that can be removed to clean things up.

Steps to Reproduce

  1. open a Tor or PB window
  2. select the Hamburger Menu -> More Tools -> Clear browsing data
  3. you’ll notice the extra spacing that appears via the bubble

Actual result:

Tor Window Example PB Window Example
image PBbubble

Expected result:

We should remove the extra spacing after removing the image from the modal via https://github.com/brave/brave-core/pull/12643.

Reproduces how often:

100% reproducible using the STR/Cases outlined above.

Brave version (brave://version info)

Brave | 1.38.57 Chromium: 99.0.4844.74 (Official Build) nightly (64-bit)
-- | --
Revision | fee9a47e86e981802390cb0d41c5ed7ea93c4f6f-refs/branch-heads/4844@{#1060}
OS | Windows 11 Version 21H2 (Build 22000.556)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:16 (5 by maintainers)

github_iconTop GitHub Comments

2reactions
fallaciousreasoningcommented, Jul 18, 2022

You might also be able to remove the close button with SetShowCloseButton in chrome/browser/ui/views/incognito_clear_browsing_data_dialog.cc#77 (via a patch like @bsclifton mentioned)

1reaction
stephendonnercommented, Sep 6, 2022

Verified PASSED using

Brave 1.44.73 Chromium: 105.0.5195.68 (Official Build) beta (x86_64)
Revision ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS macOS Version 13.0 (Build 22A5331f)

Steps:

  1. installed 1.44.73
  2. launched Brave
  3. launched a Private window via "hamburger menu" -> New Private Window
  4. launched a Private window with Tor via "hamburger menu" -> New Private Window with Tor
  5. launched a Guest window via "hamburger menu" -> Open Guest Window
  6. in each, selected "hamburger menu" -> More Tools -> Clear Browsing Data...
  7. examined and confirmed fixed vertical spacing in the Cancel Close Windows dialog
Private window Private window with Tor Guest window (unavailable)
Screenshot 2022-09-06 at 2 06 12 PM Screenshot 2022-09-06 at 2 05 36 PM Screenshot 2022-09-06 at 2 06 41 PM
Read more comments on GitHub >

github_iconTop Results From Across the Web

Clear browsing data - Computer - Google Chrome Help
Delete your browsing data · On your computer, open Chrome. · At the top right, click More More . · Click More tools...
Read more >
Clearing Browsing Data on Close - Microsoft Community Hub
Clearing Browsing Data on Close · Select Settings and more (…) and then Settings · Select Privacy and services and then click on...
Read more >
Disable 'original text' bubble inside translated page to avoid ...
Once you do, just click on the extension icon on a page in a foreign language and click "Translate this page".
Read more >
What Happens When You Clear Browsing Data in Chrome
To clear your browsing data from Chrome, go to Settings > Privacy > Clear Browsing Data. Switch to the Advanced tab to reveal...
Read more >
Cat Backpack Carrier Bubble Bag, Dog ... - Amazon.com
Cats and dogs love to keep a close eye on their surroundings. So your cutie will be able to see everything and bring...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found