Remove extra spacing from clear browsing data bubble for PT/Tor windows
See original GitHub issueDescription
After removing the images from the clear browsing data bubble for PT/Tor windows via https://github.com/brave/brave-core/pull/12643, you’ll notice that there’s some extra space that can be removed to clean things up.
Steps to Reproduce
- open a Tor or PB window
- select the
Hamburger Menu->More Tools->Clear browsing data - you’ll notice the extra spacing that appears via the bubble
Actual result:
Tor Window Example |
PB Window Example |
|---|---|
![]() |
![]() |
Expected result:
We should remove the extra spacing after removing the image from the modal via https://github.com/brave/brave-core/pull/12643.
Reproduces how often:
100% reproducible using the STR/Cases outlined above.
Brave version (brave://version info)
Brave | 1.38.57 Chromium: 99.0.4844.74 (Official Build) nightly (64-bit)
-- | --
Revision | fee9a47e86e981802390cb0d41c5ed7ea93c4f6f-refs/branch-heads/4844@{#1060}
OS | Windows 11 Version 21H2 (Build 22000.556)
Version/Channel Information:
- Can you reproduce this issue with the current release?
Yes - Can you reproduce this issue with the beta channel?
Yes - Can you reproduce this issue with the nightly channel?
Yes
Other Additional Information:
- Does the issue resolve itself when disabling Brave Shields?
N/A - Does the issue resolve itself when disabling Brave Rewards?
N/A - Is the issue reproducible on the latest version of Chrome?
N/A
Miscellaneous Information:
Issue Analytics
- State:
- Created 2 years ago
- Comments:16 (5 by maintainers)
Top Results From Across the Web
Clear browsing data - Computer - Google Chrome Help
Delete your browsing data · On your computer, open Chrome. · At the top right, click More More . · Click More tools...
Read more >Clearing Browsing Data on Close - Microsoft Community Hub
Clearing Browsing Data on Close · Select Settings and more (…) and then Settings · Select Privacy and services and then click on...
Read more >Disable 'original text' bubble inside translated page to avoid ...
Once you do, just click on the extension icon on a page in a foreign language and click "Translate this page".
Read more >What Happens When You Clear Browsing Data in Chrome
To clear your browsing data from Chrome, go to Settings > Privacy > Clear Browsing Data. Switch to the Advanced tab to reveal...
Read more >Cat Backpack Carrier Bubble Bag, Dog ... - Amazon.com
Cats and dogs love to keep a close eye on their surroundings. So your cutie will be able to see everything and bring...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found



You might also be able to remove the close button with
SetShowCloseButtoninchrome/browser/ui/views/incognito_clear_browsing_data_dialog.cc#77(via a patch like @bsclifton mentioned)Verified
PASSEDusingSteps:
1.44.73Private windowvia"hamburger menu"->New Private WindowPrivate window with Torvia"hamburger menu"->New Private Window with TorGuest windowvia"hamburger menu"->Open Guest Window"hamburger menu"->More Tools->Clear Browsing Data...CancelClose Windowsdialog