Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Default theme should be dark or light depending on Windows 10 preference

See original GitHub issue

Follow up to https://github.com/brave/brave-browser/issues/1189

This feature has been implemented on MacOS, but Windows version had some problems and is hidden behind a flag. https://github.com/brave/brave-core/pull/1805#pullrequestreview-214222419

Steps to Reproduce

Clean install
Launch Browser
Check theme settings have three options (Same as Windows, Dark, Light)
Check Same as Windows applies Windows theme to brave theme
Check Dark/Light works independently with Windows theme.

Actual result:

There is no Same as Windows in Brave colors

Expected result:

Same as Windows is available in Brave colors Same as Windows is the default option on Windows 10

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave	0.62.32 Chromium: 73.0.3683.75 (Official Build) beta (64-bit)
Revision	909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS	Windows 10 OS Build 17134.523

Brave	0.63.14 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision	909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS	Windows 10 OS Build 17134.523

cc @brave/legacy_qa @petemill @simonhong

Issue Analytics

State:
Created 5 years ago
Comments:7 (6 by maintainers)

Top GitHub Comments

1reaction

btlechowskicommented, Jun 12, 2019

Verification passed on

Brave	0.66.87 Chromium: 75.0.3770.80 (Official Build) beta (64-bit)
Revision	9a9aa15057b6b2cc0909bdcf638c0b65ecd516f2-refs/branch-heads/3770@{#948}
OS	Windows 10 OS Version 1809 (Build 17763.379)

Verified test plan from https://github.com/brave/brave-core/pull/2352 and from the description. Checked changing Same as Windows(Dark)->Same as Windows(Light) and Same as Windows(Light)->Same as Windows(Dark). Checked settings dropdown, permissions alert box (notifications, geolocation, translations, alerts) and downloads bar.

1reaction

simonhongcommented, May 2, 2019

@kjozwiak beta(C74) has Same as Windows option and it’s default. However, needs more fixes to make theme works properly on Windows like MacOS. Fix for https://github.com/brave/brave-browser/issues/4059 is merged and waiting for uplifting. Fix for https://github.com/brave/brave-browser/issues/4056 is waiting for review. When all above fixes are uplifted to C74, brave theme will work properly in Windows.