Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

should be "Same as macOS" and not "Same as MacOS" under brave colors selection

See original GitHub issue

Description

The Brave colors selection under Appearances should be Same as macOS and not Same as MacOS. Apple uses macOS.

Steps to Reproduce

launch brave and visit brave://settings and look for Brave colors: under Appearances

Actual result:

Expected result:

Should be Same as macOS and NOT Same as MacOS

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave	0.63.14 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision	909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS	Mac OS X

Reproducible on current release:

N/A as this hasn’t made it into release.

Does it reproduce on brave-browser dev/beta builds?

Yes, reproducible under Nightly/Dev.

Website problems only:

Does the issue resolve itself when disabling Brave Shields?
Is the issue reproducible on the latest version of Chrome?

Additional Information

Issue Analytics

State:
Created 5 years ago
Comments:12 (8 by maintainers)

Top GitHub Comments

2reactions

simonhongcommented, May 18, 2019

@LaurenWags I tested this on from beta(0.65.x) to nightly (0.67.x) now and all are using correct string (macOS).

1reaction

petemillcommented, Mar 27, 2019

Hi @aqeelparpia, this is a simple string change, but I’d be happy to help you contribute this change if you want to get used to the contribution process, if @kjozwiak doesn’t have something in-progress.

You should be able to search for “Same as MacOS” in a code editor to find the file. It’s in a .grd file.