[Desktop] Follow up of #9869 - `Monthly Payment` AC settings are not retained correctly in upgraded profile 1.11.x

Description

Found while testing #9869 Monthly Payment AC settings are not retained correctly in upgraded profile 1.11.x

Steps to Reproduce

Scenarios 1:

1. Clean profile 1.10.x
2. Enable rewards
3. Change AC settings values except for monthly payment (keep the monthly payment as it is)
4. Upgrade profile to 1.11.x
5. Looks for AC advanced settings value, Monthly Payment value is displayed as 0.0 BAT and dropdown values are empty
6. Rest other values are displayed as expected

Scenarios 2:

1. Clean profile 1.10.x
2. Enable rewards
3. Change AC settings monthly payment to 50 BAT or any other value
4. Upgrade profile to 1.11.x
5. Looks for AC advanced settings value, Monthly Payment value is empty in UI
6. Click on dropdown shows only 50.0 BAT and other dropdown values are empty
7. Rest other values are displayed as expected

Note: Min page time, visit and other settings are working as expected.

Actual result:

Monthly Payment AC settings are not retained correctly in upgraded profile 1.11.x Scenario1:

Scenario 2:

Expected result:

AC Advanced settings should be retained correctly in upgraded profile 1.11.x

Reproduces how often:

Always

Brave version (brave://version info)

Brave	1.11.75 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision	8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS	Windows 10 OS Version 1903 (Build 18362.900)

Version/Channel Information:

• Can you reproduce this issue with the current release? No
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the dev channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NA
• Does the issue resolve itself when disabling Brave Rewards? NA
• Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @NejcZdovc @rebron

[zenparsing]

@LaurenWags Great catch. It looks like there’s an additional issue with 1.11 (but not 1.12) where API parameters are not fetched when rewards is enabled. (I believe it’s not an issue in 1.12 because the everything is restarted every time rewards is turned on, as opposed to just when the browser is started.)

I need to spend a bit more time looking into whether a single fix will solve both issues.

[kjozwiak]

Verification PASSED on macOS 10.15.5 x64 using the following build:

Brave | 1.11.96 Chromium: 84.0.4147.89 (Official Build) (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | macOS Version 10.15.5 (Build 19F101)

Scenario #1 from https://github.com/brave/brave-browser/issues/10438#issue-644483762

Before Refresh	After Refresh

• Verified the closing/re-opening brave://rewards several times didn’t reproduce the original issue after a refresh
• Verified that restarting Brave several times didn’t didn’t reproduce the original issue after a refresh
• Verified that enabling/disabling a-c several times didn’t reproduce the original issue after a refresh

Scenario #2 from https://github.com/brave/brave-browser/issues/10438#issue-644483762

Before Refresh	After Refresh

• Verified the closing/re-opening brave://rewards several times didn’t reproduce the original issue after a refresh
• Verified that restarting Brave several times didn’t didn’t reproduce the original issue after a refresh
• Verified that enabling/disabling a-c several times didn’t reproduce the original issue after a refresh

Scenario #3 from https://github.com/brave/brave-browser/issues/10438#issuecomment-653144948

• Verified that after enabling Rewards once Brave has been updated, Monthly Payment under brave://settings doesn’t appear as 0.000 BAT
• Verified that after enabling Rewards once Brave has been updated, Monthly Payment under a-c settings doesn’t appear as 0.000 BAT

Went through the above cases with both the selected default which is 20.000 BAT and selected 50.000 BAT from the dropdown. Both cases passed without issues.

---

Verification passed on

Brave | 1.11.97 Chromium: 84.0.4147.89 (Official Build) (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | Windows 10 OS Version 1903 (Build 18362.959)

Scenario #1 from https://github.com/brave/brave-browser/issues/10438#issue-644483762

Before refresh:

After refresh:

• Verified the closing/re-opening brave://rewards several times didn’t reproduce the original issue after a refresh
• Verified that restarting Brave several times didn’t reproduce the original issue after a refresh
• Verified that enabling/disabling a-c several times didn’t reproduce the original issue after a refresh

Scenario #2 from https://github.com/brave/brave-browser/issues/10438#issue-644483762 Before refresh:

After refresh:

• Verified the closing/re-opening brave://rewards several times didn’t reproduce the original issue after a refresh
• Verified that restarting Brave several times didn’t reproduce the original issue after a refresh
• Verified that enabling/disabling a-c several times didn’t reproduce the original issue after a refresh

Scenario #3 from https://github.com/brave/brave-browser/issues/10438#issuecomment-653144948

• Verified that after enabling Rewards once Brave has been updated, Monthly Payment under brave://settings doesn’t appear as 0.000 BAT
• Verified that after enabling Rewards once Brave has been updated, Monthly Payment under a-c settings doesn’t appear as 0.000 BAT

Went through the above cases with both the selected default which is 20.000 BAT and selected 50.000 BAT from the dropdown. Both cases passed without issues.

Verification passed on

Brave	1.11.97 Chromium: 84.0.4147.89 (Official Build) (64-bit)
Revision	19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS	Ubuntu 18.04 LTS

Verified test plan from https://github.com/brave/brave-browser/issues/10438#issue-644483762

Scenario #1 Before refresh

After refresh

Scenario #2 Before refresh

After refresh

Scenario #3

• Verified that after enabling Rewards once Brave has been updated, Monthly Payment under brave://settings doesn’t appear as 0.000 BAT
• Verified that after enabling Rewards once Brave has been updated, Monthly Payment under a-c settings doesn’t appear as 0.000 BAT

Went through the above cases with both the selected default which is 20.000 BAT and selected 50.000 BAT from the dropdown. Both cases passed without issues.