Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Prevent UI reflow on google.com search results in standard adblocking mode

See original GitHub issue

Currently, when brave is in default cosmetic blocking mode, there is jitter on google.com when the 1p search ad is at first hidden, and then un-hidden after the process runs.

This issue is to put in place a short term, hacky fix to not apply ##.ads-ad on https://*.google.*/* (or similar) when brave is in the default blocking mode, to prevent jitter

this is a short term solution for a bigger, more proper default-mode-exceptions component + service

Issue Analytics

State:
Created 3 years ago
Comments:5 (3 by maintainers)

Top GitHub Comments

1reaction

pes10kcommented, Jun 28, 2020

@ryanbr that wouldn’t work bc then it would not be applied in strict / 1p blocking mode

0reactions

LaurenWagscommented, Jul 13, 2020

Verified passed with

Brave | 1.11.94 Chromium: 84.0.4147.85 (Official Build) (64-bit)
-- | --
Revision | e20c13e958edc3707db3d26d513780a7f6331a4b-refs/branch-heads/4147@{#837}
OS | macOS Version 10.14.6 (Build 18G3020)

Reproduced the reflow issue using 1.11.92 on google.com with various searches
Verified the test plan from https://github.com/brave/brave-core/pull/5991
Confirmed ads appear at the top on google.com searches (for certain searches such as remove my online footprint, samsung galaxy phone, etc) when in Standard mode for trackers & ad blocking. Confirmed the ads appear at the same time as other content, no re-flow was observed.
Confirmed ads do not appear at the top on google.com searches (again, used searches as above, from the test plan, and others) when in Aggressive mode for trackers & ad blocking.

Verification passed on


Brave | 1.11.94 Chromium: 84.0.4147.85 (Official Build) (64-bit)
-- | --
Revision | e20c13e958edc3707db3d26d513780a7f6331a4b-refs/branch-heads/4147@{#837}
OS | Windows 10 OS Version 1903 (Build 18362.900)

Verified the test plan from https://github.com/brave/brave-core/pull/5991

Confirmed ads appear at the top on google.com searches (for certain searches such as remove my online footprint, samsung galaxy phone, etc) when in Standard mode for trackers & ad blocking. Confirmed the ads appear at the same time as other content, no re-flow was observed.
Confirmed ads do not appear at the top on google.com searches (again, used searches as above, from the test plan, and others) when in Aggressive mode for trackers & ad blocking.

Verification passed on

Brave	1.11.94 Chromium: 84.0.4147.85 (Official Build) (64-bit)
Revision	e20c13e958edc3707db3d26d513780a7f6331a4b-refs/branch-heads/4147@{#837}
OS	Ubuntu 18.04 LTS

Verified the test plan from https://github.com/brave/brave-core/pull/5991

Confirmed ads appear at the top on google.com searches (for certain searches such as remove my online footprint, samsung galaxy phone, etc) when in Standard mode for trackers & ad blocking. Confirmed the ads appear at the same time as other content, no re-flow was observed.
Confirmed ads do not appear at the top on google.com searches (again, used searches as above, from the test plan, and others) when in Aggressive mode for trackers & ad blocking.

Top Results From Across the Web

See a site by turning off Chrome's ad blocker - Computer

Turn off the ad blocker ; At the top right, click More More and then Settings. ; Click Privacy and security and then...

Minimizing browser reflow | PageSpeed Insights

Reflow is the name of the web browser process for re-calculating the positions and geometries of elements in the document, for the purpose ......

How to Block Ads in Google Chrome

How to Block Ads From Chrome Settings · 1. Launch Google Chrome · 2. Access the Chrome Three Dot Menu · 3. Scroll...

Firefox and Chrome are squaring off over ad-blocker ...

Ad-blocking extensions use the feature to block incoming and outgoing traffic between certain domains and a user's browser. In particular, they ...

Banana Browser: Adblock, Secur - Apps on Google Play

Fast and secure browser that provides Adblock, Secure DNS over HTTP / HTTPS, Dark Mode, Secure Login (with your fingerprint, biometrics, pattern and...