question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Desktop] some NTP widget menus do not look nice with translations

See original GitHub issue

Description

Some of the NTP widget menus do not look nice when the translation is long, causing it to go to two lines. Would be nice if these menus could be dynamic enough to handle two lines (or more?) if needed. If you hover over one option, it should be nicely highlighted as it is in English.

Steps to Reproduce

pre-req: be using a language such as French

  1. Open NTP
  2. Click on the widget menu for Rewards

Actual result:

Because the translation for the first item on the list goes to two lines, the widget menu looks off when you hover over an option. It’s not dynamic enough to handle multiple lines as the English translation is just on one. When you hover over either option the highlighting is off. In the screenshot below, you’re hovering over the second option but the first option is partially highlighted, so this doesn’t look right. Capture d’écran 2020-07-15 à 10 30 11 AM

Expected result:

Menus should handle the translations when they go to more than one line - so if a translation is multiple lines and you hover over one, the highlighting should be as it is in English: Screen Shot 2020-07-15 at 10 43 45 AM

Reproduces how often:

easily

Brave version (brave://version info)

Brave | 1.11.97 Chromium: 84.0.4147.89 (Build officiel) (64 bits)
-- | --
Révision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
Système d'exploitation | macOS Version 10.14.6 (assemblage 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? 1.10.x yes, 1.11.x (RC) yes
  • Can you reproduce this issue with the beta channel? unsure
  • Can you reproduce this issue with the dev channel? unsure
  • Can you reproduce this issue with the nightly channel? unsure

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:6 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
srirambvcommented, Jul 15, 2020

Similar to #10742

0reactions
LaurenWagscommented, Aug 21, 2020

Verified passed with

Brave | 1.13.79 Chromium: 85.0.4183.69 (Build officiel) dev (64 bits)
-- | --
Révision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
Système d'exploitation | macOS Version 10.14.6 (assemblage 18G3020)
  • Verified STR from the issue for the languages below French: Capture d’écran 2020-08-20 à 4 32 25 PM

Norwegian: Skjermbilde 2020-08-20 kl  4 35 11 pm

Spanish: Captura de Pantalla 2020-08-20 a la(s) 4 35 50 p  m

English: Screen Shot 2020-08-20 at 4 36 27 PM

N/A - just wanted to show something that was fairly long Capture d’écran 2020-08-20 à 4 33 34 PM


Verification passed on

Brave 1.13.79 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
Revision 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS Ubuntu 18.04 LTS
  • Verified STR from the issue for the languages below Polish image

German image


Verification passed on

Brave | 1.14.59 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
-- | --
Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

English (Australia) image

Arabic image

Dutch (Netherland) image

Hindi image

Read more comments on GitHub >

github_iconTop Results From Across the Web

Menu embedded in Widget not showing translated languages
The menus show translated at the top of the page, but the ones embedded in a widget do not show the translations when...
Read more >
[Android] Include option for users to hide privacy stats ... - GitHub
Users should have a way to hide the privacy stats widget from their NTP if desired. I've seen several users make this request...
Read more >
Troubleshooting Clock Issues | pfSense Documentation
NTP is designed to periodically update the system time to account for normal drift. It cannot reasonably correct clocks that drift significantly ...
Read more >
NTP Client Shows Incorrect Time on Windows 10 [Tutorial]
NTP Client Shows Incorrect Time on Windows 10 [Tutorial]Your PC's clock is used to record the time whenever you create or modify files...
Read more >
Widgets Page - Oracle Help Center
For each show command that you can use from the ACLI to see ECB Sync, Media, Signaling, and System data about the Oracle...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found