[Desktop] some NTP widget menus do not look nice with translations
See original GitHub issueDescription
Some of the NTP widget menus do not look nice when the translation is long, causing it to go to two lines. Would be nice if these menus could be dynamic enough to handle two lines (or more?) if needed. If you hover over one option, it should be nicely highlighted as it is in English.
Steps to Reproduce
pre-req: be using a language such as French
- Open NTP
- Click on the widget menu for Rewards
Actual result:
Because the translation for the first item on the list goes to two lines, the widget menu looks off when you hover over an option. It’s not dynamic enough to handle multiple lines as the English translation is just on one. When you hover over either option the highlighting is off. In the screenshot below, you’re hovering over the second option but the first option is partially highlighted, so this doesn’t look right.
Expected result:
Menus should handle the translations when they go to more than one line - so if a translation is multiple lines and you hover over one, the highlighting should be as it is in English:
Reproduces how often:
easily
Brave version (brave://version info)
Brave | 1.11.97 Chromium: 84.0.4147.89 (Build officiel) (64 bits)
-- | --
Révision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
Système d'exploitation | macOS Version 10.14.6 (assemblage 18G3020)
Version/Channel Information:
- Can you reproduce this issue with the current release? 1.10.x yes, 1.11.x (RC) yes
- Can you reproduce this issue with the beta channel? unsure
- Can you reproduce this issue with the dev channel? unsure
- Can you reproduce this issue with the nightly channel? unsure
Other Additional Information:
- Does the issue resolve itself when disabling Brave Shields?
- Does the issue resolve itself when disabling Brave Rewards?
- Is the issue reproducible on the latest version of Chrome?
Miscellaneous Information:
Issue Analytics
- State:
- Created 3 years ago
- Comments:6 (4 by maintainers)
Top GitHub Comments
Similar to #10742
Verified passed with
French
:Norwegian
:Spanish
:English
:N/A
- just wanted to show something that was fairly longVerification passed on
German
Verification passed on
English (Australia)
Arabic
Dutch (Netherland)
Hindi