Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Support OS location service on macOS

See original GitHub issue

Upstream already has CoreLocationProvider. However, it doesn’t work if Brave is not inserted in allowed list of Location Service. If Brave is not inserted, we should use NetworkLocationProvider as a fallback

On Windows, if user doesn’t enable OS location service, NetworkLocationProvider is set even if LocationProviderWinrt flag is on. However, NetworkLocationProvider is not used on macOS as a fallback.

STR:

Check MacCoreLocationBackendStudy is enabled from brave://version
Load https://www.gps-coordinates.net/my-location
Allow location permission via site settings bubble below
Allow Brave browser for accessing os location via Preferences
Reload and check it shows correct location

Issue Analytics

State:
Created 3 years ago
Comments:8 (6 by maintainers)

Top GitHub Comments

2reactions

simonhongcommented, Jul 29, 2021

Set 1.27.x milestone as MacCoreLocationBackendStudy is also applied to current release channel. I can see MacCoreLocationBackendStudy is enabled via brave://version like below and can get accurate location. STR is added in the description. cc @kjozwiak @rebron

0reactions

kjozwiakcommented, Aug 5, 2021

Going to exclude this from the notes as this already went out via Griffin. This was more of a double check to make sure things are working as expected.