question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Expand contributon_info table

See original GitHub issue

Test Plan

Perform several auto contributes, one time tips, and recurring tips and confirm the contribution_info and contribution_info_publishers tables are populated as expected per https://github.com/brave/brave-browser/issues/6942#issuecomment-573079839

Check AC, one time tips, and recurring tips using:

  • user funded anon wallet
  • VG funded wallet
  • KYC’d uphold user wallet

Right now this is how table looks like:

image

We will need to expand it so that we can handle retry logic and logging an actual contribution data, so that we don’t need ledger_state logging anymore. Because VG simplified things a lot, tables should be quite clean. For now VG don’t need any special data that needs to be stored so we don’t need dumping table for it.

This is a current proposal:

image

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
NejcZdovccommented, Jan 10, 2020

yup

0reactions
LaurenWagscommented, Feb 3, 2020

Verified passed with

Brave 1.3.106 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS macOS Version 10.14.6 (Build 18G103)
  • Verified 1 time tip, recurring tip, and AC using previously self-funded anon wallet: anon-6942 anon-6942pt2

  • Verified 1 time tip, recurring tip, and AC using anon wallet funded via UGP (virtual) grant: Screen Shot 2020-01-31 at 3 49 59 PM Screen Shot 2020-01-31 at 3 50 16 PM

  • Verified 1 time tip, recurring tip, and AC using KYC’d user wallet: KYCd-6942 KYCd-6942pt2

Verification passed on

Brave 1.3.107 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified 1 time tip, recurring tip, and AC using previously self-funded anon wallet: image image image
  • Verified 1 time tip, recurring tip, and AC using anon wallet funded via UGP (virtual) grant: image image image
  • Verified 1 time tip, recurring tip, and AC using KYC’d user wallet: image image image

Verification passed on

Brave 1.3.107 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Ubuntu 18.04 LTS
  • Verified 1 time tip, recurring tip, and AC using previously self-funded anon wallet: image image

  • Verified 1 time tip, recurring tip, and AC using anon wallet funded via UGP (virtual) grant: image image

  • Verified 1 time tip, recurring tip, and AC using KYC’d user wallet: image image

Read more comments on GitHub >

github_iconTop Results From Across the Web

Contribution Rates and Benefit Amounts - EDD - CA.gov
Find the latest Voluntary Plan (VP) employee contribution and benefit rate. The current and prior year are shown, including how these rates are...
Read more >
COLA Increases for Dollar Limitations on Benefits and ... - IRS
The tax law places limits on the dollar amount of contributions to retirement plans and IRAs and the amount of benefits under a...
Read more >
Philhealth Contribution Table for 2019, 2020, 2021, 2022 ...
Philhealth contribution table for the years 2019, 2020, 2021, 2022, 2023, 2024 and 2025 as published by PHIC in 2019 and recently reiterated....
Read more >
SSS to increase contribution rate | The Manila Times
THE Social Security System (SSS) announced that members' contribution rate will be at 14 percent starting next year.
Read more >
Contribution Rates - PERA
Current contribution rates in effect for the Defined Benefit and Defined Contribution plans that PERA administers. Retirement plan contribution rates are ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found