question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Modify Brave Sync UI to allow one device in chain

See original GitHub issue

Description

This issue is an required addition for PR https://github.com/brave/brave-core/pull/3988 .

General notes: Sync should allow to have just one device in the chain.

This will help to avoid the situation mentioned in https://github.com/brave/brave-browser/issues/6504. Or with these hypothetical STRs:

1. enable sync on desktop
2. get busy doing something else
3. enable sync on mobile
4. shut down browser and go home
5. mobile never gets the data from the desktop because it was waiting for a second device to start syncing
6. User is angry because sync doesn't work as a user you would think that since you had enabled sync on the desktop a long time ago it should have synced everything already and then you can just connect your mobile device and get that data . 

**Required changes: **

  1. If brave://sync page is loading/reloading/sync state changed, and sync is enabled, but there are less than two devices, SyncUI page should show View Sync Code dialog.
  2. If View Sync Code is being shown, but there are less than two devices, then when the dialog is closed by cancel, SyncUI should not call Reset, and should just show the regular devices list screen and buttons.

@bradleyrichter, @darkdh , @bridiver could you please review the requested changes?

@cezaraugusto, ~you should work in branch of https://github.com/brave/brave-core/tree/sync_prefs_redo_issue_6504 , because it contains the service side changes to allow to have less than two devices in chain.~ The commit Changes in sync UI to allow test of service - subject to be redone - should be removed because it is just my attempt to allow page work when < 2 devices, so it is rough and not correct.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:8 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
cezaraugustocommented, Jan 16, 2020

@btlechowski thanks for reporting. on it right now.

@rebron yes there is a PR open for this but @AlexeyBarabash pointed me out that additional work was required, which I’m working on at this very moment.

0reactions
LaurenWagscommented, Mar 11, 2020

Marked as release-notes/exclude as per discussion with @btlechowski this was actually implemented with 1.3.x but this issue was not included in that milestone. cc @kjozwiak

Read more comments on GitHub >

github_iconTop Results From Across the Web

How do I set up Sync? - Brave Help Center
Sync Your Data - Desktop to Mobile · Open Brave Browser on your mobile device and go to Settings → Sync . ·...
Read more >
Cannot Leave Sync Chain - Brave Community
Currently only one device is stuck in this chain and it is a Windows 11 PC. I have had this issue since BEFORE...
Read more >
Syncing settings only one way on each device
To “undo” this you'll need to “Leave sync chain” from one of your device. The button to enter the code is only available...
Read more >
iPhone >< iPad - no option to add QR code - Sync
Open Brave Browser on your mobile device and go to Settings → Sync . · Select Scan or enter your sync code ....
Read more >
Can't enable synch in browser - Sync - Brave Community
Type of devices currently running on the Sync chain in question: Same desktop machine twice (Fedora 33 and Windows 10) and one mobile...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found