Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Inconsistent pluralization and missing period at end of sentence, in Brave Shields Up/Down texts

See original GitHub issue

Description

Steps to Reproduce

install 1.39.22
launch Brave
load cnn.com
click on the Shields icon in the URL bar
compare text between Shields UP and DOWN states

Actual result:

Shields UP: Note: this may reduce Brave's privacy protections. Shields DOWN: You are viewing this site without Brave's privacy protection

Shields UP	Shields DOWN

Expected result:

Shields DOWN text should probably read "You are viewing this site without Brave's privacy protections."

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.39.22 Chromium: 100.0.4896.60 (Official Build) nightly (x86_64)
Revision	6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS	macOS Version 12.4 (Build 21F5048e)

Version/Channel Information:

Can you reproduce this issue with the current release? no
Can you reproduce this issue with the beta channel? yes
Can you reproduce this issue with the nightly channel? yes

cc @nullhook @jenn-rhim @rmcfadden3 @rebron

Issue Analytics

State:
Created a year ago
Comments:6 (3 by maintainers)

Top GitHub Comments

1reaction

kjozwiakcommented, Apr 13, 2022

Removing QA Pass-macOS as this is going to be uplifted into 1.38.x via https://github.com/brave/brave-core/pull/12991 so worth checking again just in case. However, we’ll use https://github.com/brave/brave-browser/issues/22189#issuecomment-1095661528 as the verification needed to get the above uplifted.

1reaction

Tonevcommented, Apr 10, 2022

Hey, @stephendonner!

https://github.com/brave/brave-core/pull/12959

6c1uv2

Top Results From Across the Web

Shields - GitHub

Next generation Brave browser for Android, Linux, macOS, Windows. - Shields ... Inconsistent Shields' blocked-count headings between trackers & ads, ...

Untitled

Unijny rynek pracy definicja, Cek barang paketan tiki, Prouzkovane, Verify my pan card no. Mata silinder tidak pakai kacamata, Lg p788, East hempfield ......

Untitled

2 all ask's the player if they want to guess the whole word and says if it is right and ends the game...

Untitled

Mujeres de bejucos estado de mexico, Gangs of new york ending scene, Maytag lat5005aaw timer, Hay pero que bonito meme, First occurrence of...

COLLEGE ALGEBRA - The University of Central Oklahoma

The following faculty contributed to the development of OpenStax College Algebra, the text from which this product was updated and derived.