question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

IPFS badge should open native protocol scheme when local node is used

See original GitHub issue

Problem

When IPFS resolution is set to “Brave local node”, opening https://en.wikipedia-on-ipfs.org/wiki/Wikipedia/ show “IPFS” badge in address bar:

2022-02-24_20-48

but clicking on it does not open ipns://en.wikipedia-on-ipfs.org/wiki/Wikipedia/ it opens http://ipns://en.wikipedia-on-ipfs.org.ipns.localhost:48080/wiki/Wikipedia/

2022-02-24_20-48_1

Expected bahavior

Brave should open native ipfs:// or ipns://

In this specific case, it should open ipns://en.wikipedia-on-ipfs.org/wiki/Wikipedia/

Other notes

Sounds like we tested “gateway” scenario, but did not check “local node” one when testing fix for https://github.com/brave/brave-browser/issues/20567

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Reactions:2
  • Comments:6 (1 by maintainers)

github_iconTop GitHub Comments

1reaction
lidelcommented, Dec 6, 2022

ipfs://{domain-name} is invalid (DNSLink works only with ipns://), so that last error is nothing weird.

Ok to close.

0reactions
srirambvcommented, Dec 5, 2022

@lidel this seems to be fixed (mostly) for the original steps with Kubo 0.17.0. Loading https://en.wikipedia-on-ipfs.org/wiki/Wikipedia/ and clicking on the IPFS button loads ipns://en.wikipedia-on-ipfs.org/wiki/Wikipedia/, however https://github.com/brave/brave-browser/issues/21306#issuecomment-1058587291 also seems to work but fails to resolve both ipfs:// or ipns://. Are we good to close this issue as fixed with Kubo update?

https://user-images.githubusercontent.com/17010094/205680829-90ae7bf6-fc0f-4903-b2b3-e6ae802e6006.mov

Read more comments on GitHub >

github_iconTop Results From Across the Web

IPFS Support in Brave
When you have IPFS configured to use a local node, it will preserve the scheme ( ipfs: or ipns: ) in the address...
Read more >
IPFS · Devcon Archive: Ethereum Developer Conference
A look into using IPFS with Juan Batiz-Benet to distribute datastructures for various Ethereum use cases, from off-chain data, to the chain itself....
Read more >
DIF Sidetree Protocol
Sidetree nodes that participate in writing operations into the overlay network do so by anchoring Content-Addressable Storage (CAS) (e.g. IPFS) references ...
Read more >
Underlay Architecture
A node “adding a file to IPFS” doesn't force other nodes to store the file, ... node is an IPFS node extended with...
Read more >
"Cross origin requests are only supported for HTTP." error ...
This will start a web server to host your entire directory listing at ... This spins up a Node.js httpd which serves the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found