question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

ipns and ipfs URLs should not redirect/load over a Gateway in Private and Guest windows

See original GitHub issue

Description

ipns:// and ipfs:// URLs should not redirect/load over a Gateway in Private and Guest windows

See https://github.com/brave/brave-browser/issues/12978 for more details - the below testplan is from there.

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. set Method to resolve IPFS resources to Gateway in brave://settings/ipfs
  4. do either/both a Private Window / Guest Window
  5. load ipns://brantly.eth or ipfs://QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR

Actual result:

Both URLs resolve and load in Private and Guest windows (but not in Private Window with Tor).

example example
Screen Shot 2021-07-01 at 10 16 33 AM Screen Shot 2021-07-01 at 10 17 42 AM

Expected result:

Per https://github.com/brave/brave-browser/issues/12978 they shouldn’t load in Private or Guest windows.

example example
Screen Shot 2021-07-01 at 10 20 14 AM Screen Shot 2021-07-01 at 10 20 25 AM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.28.37 Chromium: 91.0.4472.124 (Official Build) nightly (x86_64)
Revision 7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS macOS Version 11.4 (Build 20F71)

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:5 (1 by maintainers)

github_iconTop GitHub Comments

1reaction
LaurenWagscommented, Jul 15, 2021

Removing QA/Blocked, 1.27.105 is available to check this issue.

0reactions
stephendonnercommented, Jul 15, 2021

Verified PASSED using the inline testplan with

Brave 1.27.105 Chromium: 92.0.4515.93 (Official Build) (x86_64)
Revision 6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile
  2. launched Brave
  3. set Method to resolve IPFS resources to Gateway in brave://settings/ipfs
  4. do either/both a Private Window / Guest Window
  5. load ipns://en.wikipedia-on-ipfs.org or ipfs://QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR

Confirmed ipns:// and ipfs:// URIs were blocked, but loaded in regular windows.

ipfs://QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR

private window guest window private window with Tor
Screen Shot 2021-07-15 at 11 37 04 AM Screen Shot 2021-07-15 at 10 25 05 AM Screen Shot 2021-07-15 at 10 25 24 AM

ipns://en.wikipedia-on-ipfs.org

private window guest window private window with Tor
Screen Shot 2021-07-15 at 11 38 09 AM Screen Shot 2021-07-15 at 11 38 18 AM Screen Shot 2021-07-15 at 11 38 25 AM
Read more comments on GitHub >

github_iconTop Results From Across the Web

Should not redirect in IPFS network delegate when resolve ...
Should not redirect in IPFS network delegate when resolve method is disabled or IPFS is disabled or in private/guest windows #12978.
Read more >
IPFS Gateway
IPFS Gateway. This document discusses: The several types of gateways. Gateway role in the use of IPFS. Appropriate situations for the use of...
Read more >
IPFS. DAG get content from web browser - Stack Overflow
HTTP Gateway provided by go-ipfs v0.4.22 supports returning files and directories only. Those are DAGs in unixfsv1 format (identified with ...
Read more >
IPNS (InterPlanetary Name System) and Mutability - IPFS Docs
Resolving IPNS names using IPFS gateways; Publishing IPNS names ... IPNS names can be thought of as links that can be updated over...
Read more >
The definitive guide to publishing content on the decentralized ...
Build a simple decentralized RESTful endpoint with minimal effort using IPFS/IPNS. Don't Panic! You Can Prepare for the Y2K Crisis, ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found