Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Question mark in peer-deletion confirmation dialog is on a new line

See original GitHub issue

Description

(Super, super minor.)

Steps to Reproduce

new profile
launch Brave
set up a peer (see #15567 for full steps)
load brave://settings/ipfs/peers
click on the trash-can icon
look at the resulting dialog

Actual result:

Do you really want to delete
12D3KooWDL8FAiiaGoTuzsAFvKrNCHA2NnaNMDNYTTaqgAszY7R4
?

Expected result:

? would preferably be on the same line; maybe truncate the long peer ID with ... or something?

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.28.37 Chromium: 91.0.4472.124 (Official Build) nightly (x86_64)
Revision	7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS	macOS Version 11.4 (Build 20F71)

Issue Analytics

State:
Created 2 years ago
Comments:10 (1 by maintainers)

Top GitHub Comments

1reaction

wadehrarshpreetcommented, May 27, 2022

@rebron seems working fine. Can see ? same line with peer ipfs address Screenshot 2022-05-27 at 11 18 54 PM

Brave v1.39.111

0reactions

deepxcodecommented, Jul 9, 2021

So instead of

      <message name="IDS_SETTINGS_IPNS_DELETE_KEY_CONFIRMATION" desc="Confirmation text for deleting a key from IPFS keys manager page">
        Do you really want to delete <ph name="KEY_NAME">$1<ex>MyCustomKey</ex></ph>?
      </message>

It will be,

      <message name="IDS_SETTINGS_IPNS_DELETE_KEY_CONFIRMATION" desc="Confirmation text for deleting a key from IPFS keys manager page">
         <ph name="KEY_NAME">$1<ex>MyCustomKey</ex></ph>
         Are you sure you want to delete this IPFS peer?
      </message>

Am I right @petemill ?