question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

.PNG .JPG and .GIF files cannot be viewed via IPFS import

See original GitHub issue

Description

Found while testing #16267 .PNG .JPG and .GIF files cannot be viewed via IPFS import

Steps to Reproduce

  1. Clean profile 1.27.x
  2. Launch brave using --use-dev-goupdater-url
  3. Make sure IPFS version is 0.9.0 in brave://ipfs-internals
  4. Import .PNG .JPG and .GIF files from the local machine
  5. Import is successful but files can’t be viewed

Actual result:

.PNG and .JPG files cannot be viewed via IPFS import image

image

Expected result:

Should be able to view .PNG and .JPG files via IPFS import

Reproduces how often:

Easy

Brave version (brave://version info)

<html> <body>
Brave 1.27.87 Chromium: 91.0.4472.124 (Official Build) beta (64-bit)
Revision 7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS Windows 10 OS Version 2004 (Build 19041.1052)
</body> </html>

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @spylogsster @brave/legacy_qa @rebron

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:8

github_iconTop GitHub Comments

2reactions
lidelcommented, Jul 2, 2021

This seems to be a variant of https://github.com/brave/brave-browser/issues/13641 however here we are on a trusted API port (45004) that tries to fetch the image from the trusted Gateway port (45083).

This is a pretty safe environment, as both Origins are controlled by Brave (brave runs go-ipfs binary, which exposes those ports)

I think the right way of fixing this class of bugs is to allow API port to fetch data from local Gateway.

1reaction
GeetaSarvadnyacommented, Aug 20, 2021

@stephendonner Apologies somehow missed the issue. Today I have verified the issue on Windows 10 x64 - 1.28.106 build issue is fixed and working fine with ipfs component 0.9.1

Read more comments on GitHub >

github_iconTop Results From Across the Web

Uploaded file is not a valid image. Only JPG, PNG and GIF ...
I'm open to suggestions. Are you using the upload.module to attach images to nodes in the "File Attachment" section of the node creation...
Read more >
hydrus network - Files - GitHub Pages
A personal booru-style media tagger that can import files and tags from your hard drive and popular websites. Content can be shared with...
Read more >
Importing products and categories - EasyWebshop
Wiki page on how to import products, variations and categories in your online store. The import file formats are CSV, spreadsheet files (LibreOffice...
Read more >
Image file types (JPG, PNG, SVG, GIF) - Web design tutorial
Understanding your image file options — and when and how to use each — can be key to building great websites. That's why...
Read more >
Which image format to you use in your design? JPG, PNG or ...
In communicators, you have to work with design in all formats, especially digital design. Learn what formats you should be using; JPG, PNG...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found