Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Crash in sidebar::SidebarService::GetNotAddedDefaultSidebarItems

See original GitHub issue

Test plan

Enable sidebar via brave://flags/#sidebar
Restart when prompted
Confirm app relaunches without crash after toggling brave://flags/#sidebar to true

Description

[ 00 ] <name omitted>
[ 01 ] <name omitted>
[ 02 ] <name omitted>
[ 03 ] sidebar::SidebarService::GetNotAddedDefaultSidebarItems() const
[ 04 ] sidebar::SidebarModel::IsSidebarHasAllBuiltiInItems() const
[ 05 ] SidebarControlView::SidebarControlView(BraveBrowser*)
[ 06 ] SidebarContainerView::Init()
[ 07 ] BraveBrowserView::InitSidebar()
[ 08 ] BraveBrowser::BraveBrowser(Browser::CreateParams const&)
[ 09 ] SessionRestoreImpl::CreateRestoredBrowser(Browser::Type, gfx::Rect, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool, ui::WindowShowState, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int)
[ 10 ] SessionRestoreImpl::ProcessSessionWindows(std::__1::vector<std::__1::unique_ptr<sessions::SessionWindow, std::__1::default_delete<sessions::SessionWindow> >, std::__1::allocator<std::__1::unique_ptr<sessions::SessionWindow, std::__1::default_delete<sessions::SessionWindow> > > >*, SessionID, std::__1::vector<SessionRestoreDelegate::RestoredTab, std::__1::allocator<SessionRestoreDelegate::RestoredTab> >*, int*, int*)
[ 11 ] SessionRestoreImpl::ProcessSessionWindowsAndNotify(std::__1::vector<std::__1::unique_ptr<sessions::SessionWindow, std::__1::default_delete<sessions::SessionWindow> >, std::__1::allocator<std::__1::unique_ptr<sessions::SessionWindow, std::__1::default_delete<sessions::SessionWindow> > > >*, SessionID)
[ 12 ] SessionRestoreImpl::Restore()

https://brave.sp.backtrace.io/p/brave/triage?filters=((callstack.functions%2Ccontains%2Csidebar)%2Cptype%3Dbrowser%2Cver>%3D"91")&aggregations=((guid%2Cunique)%2C(classifiers%2Chead))&similarity=false