Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Remove "Brave" in "Show Brave suggested sites in autocomplete suggestions" description

See original GitHub issue

Description

Remove “Brave” in “Show Brave suggested sites in autocomplete suggestions” description

Steps to Reproduce

new profile
launch Brave
load brave://settings/appearance
look at Show Brave suggested sites in autocomplete suggestions

Actual result:

Says Show Brave suggested sites in autocomplete suggestions

Expected result:

Should just be Show suggested sites in autocomplete suggestions, per discussion with @rmcfadden3 @karenkliu, as they’re not actually our suggestions

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.28.54 Chromium: 92.0.4515.81 (Official Build) nightly (x86_64)
Revision	dba3af0a9a48954c8b188bc641e651580b7cb7b5-refs/branch-heads/4515@{#1162}
OS	macOS Version 11.4 (Build 20F71)

Version/Channel Information:

Can you reproduce this issue with the current release? yes
Can you reproduce this issue with the beta channel? yes
Can you reproduce this issue with the nightly channel? yes

Issue Analytics

State:
Created 2 years ago
Comments:11 (8 by maintainers)

Top GitHub Comments

1reaction

bbondycommented, Apr 2, 2022

Actually I see the PR is already there and approved and correct, so I’ll take that back and re-open.

1reaction

bscliftoncommented, Apr 1, 2022

@Tonev just assigned @mkarolin for review; some of the localizations can be tricky, because they get auto-generated. I suspect it may need to be changed another place. For example, we’ll auto-replace a set of words on Chromium upgrade and do a replace of Google with Brave