question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Missing period in Tor/.onion Settings description

See original GitHub issue

Description

Missing period in Tor/.onion Settings description

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. load brave://settings/extensions
  4. look at the Automatically redirect .onion sites section

Actual result:

Screen Shot 2021-06-09 at 3 45 50 PM

Expected result:

Should have a period at the end of the descriptive sentence; additionally, the copy itself seems a bit stilted.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.26.54 Chromium: 91.0.4472.88 (Official Build) beta (x86_64)
Revision 109e9cd038b94a631aea7d40ee3d56c1278f2597-refs/branch-heads/4472@{#1385}
OS macOS Version 11.4 (Build 20F71)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:8 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
tonycoldashiancommented, Jun 15, 2021

Hey @bsclifton , I opened a PR with my contribution. It’s my first time on open source, sorry if something is not right.

0reactions
stephendonnercommented, Jun 17, 2021

Verified FIXED using

Brave 1.28.3 Chromium: 91.0.4472.106 (Official Build) nightly (x86_64)
Revision 574f7b38e4e7244c92c4675e902e8f8e3d299ea7-refs/branch-heads/4472@{#1477}
OS macOS Version 11.4 (Build 20F71)
Screen Shot 2021-06-17 at 3 00 27 PM
Read more comments on GitHub >

github_iconTop Results From Across the Web

Defending Against Malicious Cyber Activity Originating from Tor
Using the Onion Routing Protocol, Tor software obfuscates a user's identity from anyone seeking to monitor online activity (e.g., nation states,.
Read more >
Onion Router - an overview | ScienceDirect Topics
The Onion Router (Tor) is a significant tool in the “I need to hide on the Internet” world (Figure 9.6). Tor was developed...
Read more >
V3 onion services usage | The Tor Project
Its purpose is to provide the information needed to connect to a specified onion address (just like the DNS system does for regular...
Read more >
Improving the Privacy of Tor Onion Services⋆
As clients maintain their guard node for a long period of time (currently up to six months) [33,14], the guard relay itself provides...
Read more >
torspec/rend-spec-v3.txt at main - GitHub
d) Better onion address security against impersonation. ... For each period, the Tor directory authorities agree upon a.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found