question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Typos on Brave Rewards onboarding tour slides

See original GitHub issue

Description

Typos on Brave Rewards onboarding tour slides

Steps to reproduce

  1. install Brave nightly
  2. tap on the BAT icon with the question mark in the URL bar
  3. tap on the Take a quick tour link
  4. look at the copy for the 1st and 3rd slides

Actual result

  • The 1st slide reads LETS TAKE A QUICK TOUR (missing ')
  • The 2nd slide reads When do you receive rewards (missing ?)
1st slide 3rd slide
Screenshot_20210609-150911 Screenshot_20210609-150922

Expected results

  • The 1st slide should read LET'S TAKE A QUICK TOUR
  • The 3rd slide should read When do you receive rewards?

Issue reproduces how often

100%

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86): ARM64
  • Device type (Phone, Tablet, Phablet): Google Pixel phone
  • Android version: 9.0

Brave version

Brave 1.27.51, Chromium 91.0.4472.88

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:9

github_iconTop GitHub Comments

1reaction
stephendonnercommented, Jun 11, 2021

Hello, @stephendonner , I saw the Typos, I like to contribute to this I’m new to contribute. I am working on this I try to solve it as fast as possible.

can anyone suggest to me where can I start, which code files I work on?

🙏 Thanks for this issue.

Hi @PrashantIndurkar the best way to learn is to start searching through https://github.com/brave/brave-core for the relevant strings, and take it from there; thanks for working on this! Assigning to you; please un-assign if you for whatever reason change your mind.

0reactions
stephendonnercommented, Jul 20, 2021

Verified FIXED using Brave - Nightly 1.29.12, Chromium 92.0.4515.101 on a Google Pixel XL, running Android 9.

Steps:

  1. installed Brave nightly
  2. tapped on the BAT icon with the question mark in the URL bar
  3. tapped on the Take a quick tour link
  4. looked at the copy for the 1st and 3rd slides

Confirmed it now correctly reads LET'S TAKE A QUICK TOUR (1st slide) and When do you receive rewards? (3rd slide).

1st slide 3rd slide
Screenshot_20210720-115802 Screenshot_20210720-115815
Read more comments on GitHub >

github_iconTop Results From Across the Web

Remove/hide and modify A-C slides in onboarding tours when ...
Solution · In Take a Tour path, there is a SLIDE 1 about A-C. This should be hidden/removed if region == Japan. ·...
Read more >
What is Brave Rewards? | Brave Browser
Brave Rewards. Earn tokens just for browsing. Use them for almost anything: Cash gift cards. Crypto. Tips to the websites & content creators...
Read more >
Why is Brave Rewards profile flagged?
Opened a ticket on 10/6/22 asking for some form of explanation as to why it's flagged or what I can do to “unflag”...
Read more >
How do I tip websites and Content Creators in Brave Rewards?
Within ten days of Brave's receipt of your tip, the content creator you tipped will be able to log into their Brave Creators...
Read more >
How to Disable these Notifications (from Brave Rewards)
Hi, I love this browser more every day. Unfortunately, I am getting a notification I cannot figure out how to prevent.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found