question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Open using IPFS badge always shown when using IPFS gateway

See original GitHub issue

Description

Open using IPFS badge always shown when using IPFS gateway

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. load ipns://brantly.eth
  4. click on Public Gateway
  5. in the resulting page (https://brantly-eth.ipns.dweb.link/#/), note the presence of the Open using IPFS badge in the URL bar
  6. click on it

Actual result:

ipfs-gateway-open

Expected result:

Unsure

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.28.27 Chromium: 91.0.4472.120 (Official Build) nightly (x86_64)
Revision 12c5925972cffe578ca7ca7a295e98ee7e178a7a-refs/branch-heads/4472@{#1506}
OS macOS Version 11.4 (Build 20F71)

/cc @lidel @spylogsster

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:5

github_iconTop GitHub Comments

2reactions
lidelcommented, Jul 1, 2021

Agree with @stephendonner – we should hide the badge when we are on a page that belongs to the Gateway selected by the user ( to avoid meaningless/confusing re-open in a new tab).

The test for hiding badge would be:

if (new URL(window.location.origin).host.endsWith(new URL("https://dweb.link").host)) {
   // already on final gateway, hide badge
}

Where https://dweb.link is the public (or local) Gateway used for ipfs:// resolution

0reactions
stephendonnercommented, Jul 6, 2021

Verified PASSED using the inline testplan on build

Brave 1.28.54 Chromium: 92.0.4515.81 (Official Build) nightly (x86_64)
Revision dba3af0a9a48954c8b188bc641e651580b7cb7b5-refs/branch-heads/4515@{#1162}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile
  2. launched Brave
  3. loaded ipns://brantly.eth
  4. clicked on Public Gateway
  5. confirmed I no longer got Open using IPFS badges
example example
Screen Shot 2021-07-06 at 4 14 13 PM Screen Shot 2021-07-06 at 4 14 20 PM

Also tried with https://ipfs.io/ipfs/QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR (badge) -> ipfs://bafybeigdyrzt5sfp7udm7hu76uh7y26nf3efuylqabf3oclgtqy55fbzdi/ (no badge) and https://en.wikipedia-on-ipfs.org/wiki/ (badge) -> ipns://en.wikipedia-on-ipfs.org/wiki/ (no badge)

badge no badge badge no badge
Screen Shot 2021-07-06 at 4 20 26 PM Screen Shot 2021-07-06 at 4 20 30 PM Screen Shot 2021-07-06 at 4 20 33 PM Screen Shot 2021-07-06 at 4 20 37 PM
Read more comments on GitHub >

github_iconTop Results From Across the Web

Bug: "Open using IPFS" badge broken on local gateway URLs ...
found in nightly-1.27.25-linux-amd64) Opening a path gateways URL ... Bug: "Open using IPFS" not shown on public subdomain gateways #16116.
Read more >
IPFS Gateway
The ipfs.io gateway is a community resource run by Protocol Labs to help developers build on IPFS.
Read more >
Mint an NFT with IPFS
Mint an NFT with IPFS. Non-fungible tokens (NFTs) allow users to create and trade digital items with differing values. Go from nothing to...
Read more >
Overview - Documentation - Fleek docs
This gateway directly fetches the information on IPFS, meaning it will always display the exact content of the file on IPFS.
Read more >
How to Make & Run a Public IPFS Gateway on AWS - DataStax
We'll introduce you to IPFS gateways and show you how to run your own to store NFT ... Let's start with an introduction...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found