Open using IPFS badge always shown when using IPFS gateway
See original GitHub issueDescription
Open using IPFS
badge always shown when using IPFS gateway
Steps to Reproduce
- new profile
- launch Brave
- load
ipns://brantly.eth
- click on
Public Gateway
- in the resulting page (
https://brantly-eth.ipns.dweb.link/#/
), note the presence of theOpen using IPFS
badge in the URL bar - click on it
Actual result:
Expected result:
Unsure
Reproduces how often:
100%
Brave version (brave://version info)
Brave | 1.28.27 Chromium: 91.0.4472.120 (Official Build) nightly (x86_64) |
---|---|
Revision | 12c5925972cffe578ca7ca7a295e98ee7e178a7a-refs/branch-heads/4472@{#1506} |
OS | macOS Version 11.4 (Build 20F71) |
/cc @lidel @spylogsster
Issue Analytics
- State:
- Created 2 years ago
- Comments:5
Top Results From Across the Web
Bug: "Open using IPFS" badge broken on local gateway URLs ...
found in nightly-1.27.25-linux-amd64) Opening a path gateways URL ... Bug: "Open using IPFS" not shown on public subdomain gateways #16116.
Read more >IPFS Gateway
The ipfs.io gateway is a community resource run by Protocol Labs to help developers build on IPFS.
Read more >Mint an NFT with IPFS
Mint an NFT with IPFS. Non-fungible tokens (NFTs) allow users to create and trade digital items with differing values. Go from nothing to...
Read more >Overview - Documentation - Fleek docs
This gateway directly fetches the information on IPFS, meaning it will always display the exact content of the file on IPFS.
Read more >How to Make & Run a Public IPFS Gateway on AWS - DataStax
We'll introduce you to IPFS gateways and show you how to run your own to store NFT ... Let's start with an introduction...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Agree with @stephendonner – we should hide the badge when we are on a page that belongs to the Gateway selected by the user ( to avoid meaningless/confusing re-open in a new tab).
The test for hiding badge would be:
Where
https://dweb.link
is the public (or local) Gateway used foripfs://
resolutionVerified
PASSED
using the inline testplan on buildSteps:
ipns://brantly.eth
Public Gateway
Open using IPFS
badgesAlso tried with
https://ipfs.io/ipfs/QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR
(badge) ->ipfs://bafybeigdyrzt5sfp7udm7hu76uh7y26nf3efuylqabf3oclgtqy55fbzdi/
(no badge) andhttps://en.wikipedia-on-ipfs.org/wiki/
(badge) ->ipns://en.wikipedia-on-ipfs.org/wiki/
(no badge)