Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

relabel search engine name to "Brave"

See original GitHub issue

Description

We currently have search engine name set as Brave Search beta but the label looks awkward when searching from the url bar.

Search engine name should just be Brave and searches from url bar should show [query] - Brave Search

Steps to Reproduce

Download 1.26.67.
Change default search engine to Brave Search beta from brave://settings/search
Perform a search and notice [query] - Brave Search beta Search

Actual result:

image__42_

Expected result:

When searching from URL bar - Screen Shot 2021-06-22 at 6 17 31 PM

Manage Settings drop down - Screen Shot 2021-06-22 at 6 21 05 PM

Other Search engines list - Screen Shot 2021-06-22 at 6 22 00 PM

Reproduces how often:

Easily.

Brave version (brave://version info)

1.26.67

Version/Channel Information:

Can you reproduce this issue with the current release? yes
Can you reproduce this issue with the beta channel? yes
Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields? n/a
Does the issue resolve itself when disabling Brave Rewards? n/a
Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Issue Analytics

State:
Created 2 years ago
Comments:5 (3 by maintainers)

Top GitHub Comments

1reaction

kjozwiakcommented, Jun 29, 2021

Clearing QA Pass-macOS so we can make sure the above is working correctly once we get 1.26.x RC’s as Brave Search is pretty important 👍

0reactions

srirambvcommented, Jun 30, 2021

Verification passed on OnePlus 6T with Android 10 running 1.26.74 x64 build Clean Install

Verified Brave Search beta is updated to Brave during onboarding
Verified selecting Brave during onboarding sets it as default for both normal and private tabs

**Upgrade Install (with Brave as default)

Verified upgrading to 1.26.74 updates the Search engine name for both standard and private tabs in selection view
Verified upgrading to 1.26.74 retains Brave Search beta on Search engines overview page

Upgrade Install (with Brave not set as default)

Verified upgrading retains the SE list correctly and default SE
Verified upon upgrade Brave Search beta is replaced by Brave for both standard and private tabs in selection view

Verification passed on Samsung Tab A with Android 10 running 1.26.74 x64 build Clean Install

Verified Brave Search beta is updated to Brave during onboarding
Verified selecting Brave during onboarding sets it as default for both normal and private tabs

**Upgrade Install (with Brave as default)

Verified upgrading to 1.26.74 updates the Search engine name for both standard and private tabs in selection view
Verified upgrading to 1.26.74 retains Brave Search beta on Search engines overview page

Upgrade Install (with Brave not set as default)

Verified upgrading retains the SE list correctly and default SE
Verified upon upgrade Brave Search beta is replaced by Brave for both standard and private tabs in selection view