question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

PDFJS not installed by default

See original GitHub issue

Description

@GeetaSarvadnya and myself have run into an issue where PDFJS is not being installed for us with clean profiles. I noticed that the last time it appears to have been installed by default was with version 0.54.4. From 0.55.1 onward it is not installed by default for me. (unsure if @GeetaSarvadnya sees the same) I’m using macOS 10.12.6

Steps to Reproduce

  1. Use rm -rf ~/Library/Application\ Support/BraveSoftware and rm -rf ~/Library/Caches/BraveSoftware to remove any existing Brave data
  2. Delete app from Applications folder and delete existing .dmg file.
  3. Download 0.55.1 or later.

Actual result:

PDFJS is not installed by default 0551-nopdfjs

Expected result:

PDFJS installed by default 0544-pdfjs

Reproduces how often:

easily

Brave version (chrome://version info)

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? n/a
  • Does it reproduce on browser-laptop? n/a

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

cc @GeetaSarvadnya @srirambv who also experienced the issue however @kjozwiak did not.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:14 (13 by maintainers)

github_iconTop GitHub Comments

2reactions
yrlioucommented, Oct 1, 2018

PDF Viewer should be shown without that argument.

0reactions
LaurenWagscommented, Oct 15, 2018

Verified passed with

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X

Verification Passed on

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux

image

Verification passed on

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Windows 7

image

Read more comments on GitHub >

github_iconTop Results From Across the Web

How do I run default pdf viewer not "pdf.js"?
If your browser open the pdf file with pdfjs instead of Edge pdf viewer mode, check settings of browser extension and release the...
Read more >
PDFjs not Installed - asp.net mvc
I am trying to use PDF.js to view PDFs in my ASP.Net MVC application via Angularjs. However, when I use the Nuget package...
Read more >
Getting Started
With the prebuilt or source version, open web/viewer.html in a browser and the test pdf should load. Note: the worker is not enabled...
Read more >
pdf.js-extract
pdfs-dist installs not needed dependencies into production deployment. Note: NO OCR! Install. NPM. test license. Example Usage. javascript async ...
Read more >
Islandora PDF.js
Note: If you use the Drush command, it is advisable to Move (not copy) the install script to your.drush folder and run it....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found