question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Reduce adblock filter memory usage by optimizing unused regex rules

See original GitHub issue

As discovered by @atuchin-m, there is an extra ~7MB that can be saved by optimizing the regex field of NetworkFilter in adblock-rust. This was fixed in adblock-rust as of v0.5.2.

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:6 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
atuchin-mcommented, Mar 30, 2022

For QA: we should verify, that browser process memory consumption became 7mb less. A possible scenario:

  1. Launch browser without the fix with one saved tab about:blank
  2. Wait 15 sec.
  3. Check browser process memory footprint in the internal task manager (see a screenshot)
  4. Repeat a few times to make the results stable (3-5 times)
  5. Repeat 1-4 for browser with the fix image
0reactions
kjozwiakcommented, May 24, 2022

Verification PASSED on Samsung S10+ running Android 12 using the following build(s):

Brave | 1.39.111 Chromium: 102.0.5005.61 (Official Build) (64-bit)
--- | ---
Revision | 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS | Android 12; Build/SP1A.210812.016
1.38.119 (370.2 MB) 1.38.119 (318 MB) 1.38.119 (304.5 MB) 1.38.119 (302.4 MB) 1.38.119 (316.2 MB)
image image image image image
1.39.111 (310.6 MB) 1.39.111 (314 MB) 1.39.111 (312 MB) 1.39.111 (297.7 MB) 1.39.111 (308.3 MB)
image image image image image

Verification PASSED on Samsung Galaxy Tablet A running Android 11 using the following build(s):

Brave | 1.39.111 Chromium: 102.0.5005.61 (Official Build) (64-bit)
--- | ---
Revision | 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS | Android 11; Build/RP1A.200720.012
1.38.119 (214.3 MB) 1.38.119 (176.2 MB) 1.38.119 (232.6 MB) 1.38.119 (204.4 MB) 1.38.119 (202.4 MB)
image image image image image
1.39.111 (154 MB) 1.39.111 (177.6 MB) 1.39.111 (161.4 MB) 1.39.111 (160.9 MB) 1.39.111 (149.5 MB)
image image image image image
Read more comments on GitHub >

github_iconTop Results From Across the Web

AdBlock is using lots of memory
Open and then close AdBlock's options page. In AdBlock's options, disable EasyList and AdBlock Custom, and then enable them again.
Read more >
Release Channel 1.39.111 - Brave Community
(#20780); Reduced adblock filter memory usage by optimizing unused regex rules. (#21970); Removed known Dialog Insight user tracking ...
Read more >
Release Channel 1.39.111 : r/brave_browser - Reddit
Reduced adblock filter memory usage by optimizing unused regex rules. (#21970). Removed known Dialog Insight user tracking parameters from ...
Read more >
Adblock Plus is probably the reason Firefox and Chrome are ...
In some tests, uBlock results in the browser using less memory than with no ... Bottom line, whatever filter lists you use in...
Read more >
Not all adblockers are born equal - Tech @ Cliqz
Adblockers use such capabilities whenever blocking requests is not ... Cliqz supports the Adblock Plus (“ABP”) filter syntax, as well as ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found