question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

(Windows only) Text in tab bar is sometimes unreadable depending on brave colors and windows accent color

See original GitHub issue

Description

On windows, having a lighter accent color causes the text on unselected tabs, as well as the new tab icon in the tab bar to become dark and unreadable when using the default dark theme. Having a darker accent color causes the text to become unreadable in the light color theme

Steps to Reproduce

  1. install 1.37.109 on windows
  2. set accent color in windows settings > Personalization > Colors to a lighter color such as green or red
  3. scroll down to Show accent color on the following surfaces and make sure that Title bars and window borders is checked
  4. launch brave
  5. go to brave://settings/appearance
  6. set Brave colors to Dark
  7. open more than one tab

Actual result:

Tab text and new tab icon is black and pretty much unreadable. image

Expected result:

Tab text and new tab icon should be a lighter color in the dark theme

Reproduces how often:

Only on when Brave colors is Dark and accent color is a lighter color, or when Brave colors is Light and accent color is a darker color

Brave version (brave://version info)

<html> <body>
Brave 1.37.109 Chromium: 100.0.4896.60 (Official Build) (64-bit)
Revision 6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS Windows 10 Version 21H1 (Build 19043.1586)
</body> </html>

Version/Channel Information:

The problem is also present on the current nightly release 1.39.22

Other Additional Information:

The same behavior happens on chromium, but since the top bar on chromium is set to the color of the windows accent color, the text is still readable. Since the top bar is always dark colored in the brave dark theme, the text just becomes unreadable.

How it looks in chromium 102.0.4977.0 side by side with how it looks in brave 1.37.109: image

With a darker color the text becomes white: image

However, it becomes unreadable in the light theme: image

Issue Analytics

  • State:closed
  • Created a year ago
  • Reactions:14
  • Comments:21 (3 by maintainers)

github_iconTop GitHub Comments

4reactions
kjozwiakcommented, Apr 17, 2022

I’m new in GitHub. The problem wasn’t fixed on Windows 8.1. I’m not finding an opened issue to deal with it, Do we have to open a new one?

Thanks for all the reports 👍 I managed to reproduce the issue and created https://github.com/brave/brave-browser/issues/22365 as a follow up for Win 8. As per the confirmations above, looks like the issue was resolved for both Win 11 & Win 10 but is still a problem within Win 8. Assuming it’s due to Win 8 using a different theming/colour implementation compared to Win 11 & Win 10. We’ll try getting this fixed ASAP 👍

2reactions
LaurenWagscommented, Apr 13, 2022

Hi @amzero - we’re aiming to release a version with this fix tomorrow. Stay tuned!

Read more comments on GitHub >

github_iconTop Results From Across the Web

Brave tabs titles have unreadable colors after last update
(Windows only) Text in tab bar is sometimes unreadable depending on brave colors and windows accent color. opened 09:47PM - 31 Mar 22...
Read more >
Titles of Tabs unreadable in new update - Brave Community
(Windows only) Text in tab bar is sometimes unreadable depending on brave colors and windows accent color. Super! thanks.
Read more >
Tab text light grey in Windows light mode - Brave Community
Go to Windows settings → personalization → colors and turn on / select “Light” under “Choose your color” · Unselected tabs' text appears...
Read more >
Names of tabs hardly visible/invisible on dark mode
(Windows only) Text in tab bar is sometimes unreadable depending on brave colors and windows accent color.
Read more >
Site names do not appear (are blank) on non-active tabs
(Windows only) Text in tab bar is sometimes unreadable depending on brave colors and windows accent color ... This topic was automatically closed ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found