Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Remove P3A protobuf reporting

See original GitHub issue

Description

Reverting P3A protobuf submission is done via the PR https://github.com/brave/brave-core/pull/14015/ and which resolves the issue https://github.com/brave/brave-browser/issues/23754 and the same is verified in 1.41.x https://github.com/brave/brave-browser/issues/23754#issuecomment-1176443588 and ensured P3A and P2A work as it works in 1.40.x

The actual fix for Remove P3A protobuf reporting is merged in 1.42.x and 1.43.x via the PR https://github.com/brave/brave-core/pull/14017 hence created this issue to address Remove P3A protobuf reporting in 1.42.x

Test Plan:

Run browser under a network proxy for traffic inspection

With a fresh profile, wait 10-15 minutes for P3A reports to be sent.
Confirm messages all go the p3a-json.brave.com and are formatted as readable json. There should be no traffic to p3a.brave.com.
P2A messages are unaffected and may go to p2a.brave.com, p2a-json.brave.com or both, depending on the version. This change is only about Brave.P3A.* reports.

Miscellaneous Information:

Discussed with @kjozwiak and created the issue.

cc: @brave/legacy_qa @rillian @mattmcalister @rebron

Issue Analytics

State:
Created a year ago
Comments:11 (1 by maintainers)

Top GitHub Comments

1reaction

srirambvcommented, Aug 2, 2022

Verification passed on Oppo Reno 5 with Android 12 running 1.42.85 x64 build

Verified traffic is not sent to old endpoint p3a.brave.com
Verified that all the P3A metrics are sent in JSON format to p3a-json.brave.com
Verified around 17 metric that are sent for P3A is available in brave://local-state
Verified no P2A metrics are sent (known issue)

1reaction

rilliancommented, Jul 14, 2022

At least it sounds like an improvement instead of a regression.

Top Results From Across the Web

Language Guide | Protocol Buffers - Google Developers

If you update a message type by entirely removing a field, or commenting it out, future users can reuse the field number when...

Source compatibility report for Protocol Buffers: 2.5.0 vs 2.6.0

This method is from 'Descriptors.MethodDescriptor' class. ... Removed super-interface Descriptors.GenericDescriptor. Recompilation of a client program may be ...

Release Channel 1.42.86 - Release Notes - Brave Community

(#22672); Removed P3A protobuf reporting. (#23147); Removed “Get image description from Brave” context menu option.

Publish messages of protobuf schema type | Cloud Pub/Sub ...

Publish messages that conform to a protocol buffer schema to a topic with a protocol buffer schema attached.

Java: Deleting from lists in protobufs - Google Groups

to Protocol Buffers. How do I delete an entry from a list in a protobuf (repeated field)? I can add, I can modify,...