question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

remove Set default search engine screen for AT / ES / MX

See original GitHub issue

Test plan

See https://github.com/brave/brave-browser/issues/23814

Description

in brave://welcome remove Set default search engine screen for the following locales: AT / ES / MX / MT Austria, Spain, Mexico, Malta

135164087-0e746789-834d-49b8-86ca-4b19d33786db

Expected Result

  1. Install Brave from the following locales AT / ES / MX
  2. Set default search engine screen should be removed from AT / ES / MX (and previously CA / DE / FR / GB / US). Screen should remain for all other locales.
  3. Onboarding should be four steps now instead of five.

Brave version (brave://version info)

Target version is 1.42.x

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Dependency on https://github.com/brave/brave-browser/issues/23814 Previous work for removing screen in CA/DE/FR/GB/US here: https://github.com/brave/brave-browser/issues/18415

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:9 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
kjozwiakcommented, Jul 26, 2022

@brave/qa-team as discussed with @rebron, we don’t need to run through each locale like I did via https://github.com/brave/brave-core/pull/14177#issuecomment-1195042499 on Nightly before uplifted. On each platform, we can check the following:

  • single check on either AT, ES or MX
  • single check on either CA, DE, FR, GB or US
  • single check of a locale that isn’t listed above to ensure that Brave Search isn’t default and the search screen is still visible via brave://welcome during onboarding.

Please coordinate so we’re not doing the same locales twice when verifying via 1.42.x.

1reaction
deeppandyacommented, Jul 8, 2022
Read more comments on GitHub >

github_iconTop Results From Across the Web

remove Set default search engine screen for BR / AR #26182
Set default search engine screen should be removed from BR / AR (and previously CA / DE / FR / GB / US...
Read more >
Set your default search engine & site search shortcuts
Set your default search engine · On your computer, open Chrome. · At the top right, click More More and then Settings. ·...
Read more >
How to Change Your Default Search Engine - Business Insider
1. Open the Google Chrome app and tap the three stacked dots in the top-right corner, then select Settings. · 2. Under Basics,...
Read more >
How to Change the Default Search Engine on All ... - Kinsta
Removing a search engine is easy. On the Settings page, scroll to Search Shortcuts and highlight the search engine you want to delete....
Read more >
How to Change Your Default Search Engine in Chrome, Edge ...
To Set a Default Search Engine, Edit, or Delete ... Click the Manage search engines arrow right below the default search engine list...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found